Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages: init he and escape-string-regexp #86773

Closed
wants to merge 2 commits into from
Closed

nodePackages: init he and escape-string-regexp #86773

wants to merge 2 commits into from

Conversation

expipiplus1
Copy link
Contributor

These are a prerequisite for building the Vulkan
documentation. Vulkan-Docs
doesn't come with a well-formed package.json which makes it difficult to
use with node2nix or other tools. Having these packages here makes it
very easy.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels May 4, 2020
@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@prusnak prusnak added 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs labels May 30, 2020
@expipiplus1
Copy link
Contributor Author

@prusnak I have rebased on master.

@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label May 31, 2020
prusnak
prusnak requested changes May 31, 2020
View reviewed changes
pkgs/development/node-packages/node-packages.nix
buildInputs = globalBuildInputs;
meta = {
description = "A robust HTML entities encoder/decoder with full Unicode support.";
homepage = https://mths.be/he;
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this come from node2nix? As per RFC45 the URLs should be quoted:

Suggested change
homepage = https://mths.be/he;
homepage = "https://mths.be/he";

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

done, thanks

@expipiplus1
Copy link
Contributor Author

Is it possible to get this merged, please?

@veprbl
Copy link
Member

veprbl commented Jun 11, 2020

Landed as 74ff4f6 and d6c0115

@veprbl veprbl closed this Jun 11, 2020
@expipiplus1
Copy link
Contributor Author

expipiplus1 commented Jun 11, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@prusnak prusnak prusnak approved these changes

Assignees
No one assigned
Labels
6.topic: nodejs 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@expipiplus1 @prusnak @veprbl