Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

python3Packages.hydra-check: init at 1.1.1 #84917

Merged
merged 1 commit into from
Apr 13, 2020
Merged

python3Packages.hydra-check: init at 1.1.1 #84917

merged 1 commit into from
Apr 13, 2020

Conversation

makefu
Copy link
Contributor

@makefu makefu commented Apr 10, 2020

Motivation for this change

Add hydra-check into upstream nixpkgs. closes nix-community/hydra-check#6

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@makefu makefu requested review from FRidh and jonringer as code owners April 10, 2020 17:10
@makefu makefu force-pushed the pkgs/hydra-check/init branch 2 times, most recently from 64165fa to 63b4791 Compare April 11, 2020 10:53
@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Apr 11, 2020
bhipple
bhipple requested changes Apr 12, 2020
View reviewed changes
Copy link
Contributor

@bhipple bhipple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great to see this making its way into nixpkgs proper!

pkgs/development/python-modules/hydra-check/default.nix Outdated
repo = "hydra-check";
rev = version;
sha256 = "1dmsscsib8ckp496gsfqxmq8d35zs71n99xmziq9iprvy7n5clq2";

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change

Nit: extra whitespace here

pkgs/development/python-modules/hydra-check/default.nix
flake8 hydracheck
echo -e "\x1b[32m## run mypy\x1b[0m"
mypy hydracheck
'';
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would not do any of these checks inside the nix distribution: this will cause build failures when someone else goes to upgrade the version of black or flake8 or mypy, but these linting considerations are at the project src repo level, so they belong just in your CI for the project.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

i agree with black and flake8 but mypy seems to also check type hints. It might be useful to include it in case something changes with the next python version, no?

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think that's fair. But mypy has also know to break some APIs, although I can't think of any in particular.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or maybe it was that it became more strict. Either way, I've seen where a bump in mypy has caused failures

pkgs/development/python-modules/hydra-check/default.nix Outdated
'';

meta = with lib;{
homepage = https://github.com/nix-community/hydra-check;
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
homepage = https://github.com/nix-community/hydra-check;
homepage = "https://github.com/nix-community/hydra-check";

Quote for NixOS/rfcs#45

@makefu makefu force-pushed the pkgs/hydra-check/init branch from 63b4791 to b02211c Compare April 13, 2020 11:58
jonringer
jonringer approved these changes Apr 13, 2020
View reviewed changes
Copy link
Contributor

@jonringer jonringer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Result of nixpkgs-review pr 84917 1

2 packages built: - hydra-check (python37Packages.hydra-check) - python38Packages.hydra-check

@jonringer jonringer merged commit 382fcf9 into NixOS:master Apr 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bhipple bhipple bhipple requested changes

@jonringer jonringer jonringer approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) This PR adds a new package 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add to Nixpkgs?
3 participants
@makefu @bhipple @jonringer