-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
nodePackages.clean-css: rename to clean-css-cli #84577
Conversation
7dda1fa
to
9d5c23a
Compare
I got 2 PRs' commits mixed, the current set of commits should be relevant only for clean-css-cli now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
All files look good to me :)
Please rework your PR. It now has a merge conflict after PR #89184 has been merged |
d0848ee
to
caffce7
Compare
Fixed merged conflicts. |
@GrahamcOfBorg build nodePackages.clean-css-cli |
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: |
caffce7
to
2f0c382
Compare
We likely may need to do something with base64 hashes (e.g. apply #89520). Meanwhile, I think, the PR could stick to changing node-packages.json file only. |
@veprbl how often does someone run |
Landed as 9a47504
If you are asking for a suggestions, I'm not sure what to tell you. While I was applying this PR and another one, some other upstream dependencies had already been bumped. The way it is now, any PR that regenerates node-packages.nix will pick up irrelevant changes that would always lead to merge conflicts. Perhaps, it would work a bit more predictably if node2nix could fetch some specific snapshot of the npm registry. |
Motivation for this change
Fix #82527 . (cc @justinlovinger ).
Things done
git add -p
to add only relevant updates.sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)