Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

home-manager: 2020-03-07 -> 2020-03-17 #83763

Merged
merged 1 commit into from
Mar 30, 2020
Merged

home-manager: 2020-03-07 -> 2020-03-17 #83763

merged 1 commit into from
Mar 30, 2020

Conversation

timokau
Copy link
Member

@timokau timokau commented Mar 30, 2020 •
edited
Loading

Motivation for this change

Includes nix-community/home-manager#1099 and services.keynav.

I've tested this by rebuilding my own system configuration with it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ofborg ofborg bot requested a review from rycee March 30, 2020 09:52
@timokau timokau merged commit fe9ea7a into NixOS:master Mar 30, 2020
@timokau timokau deleted the home-manager-2020-03-17 branch March 30, 2020 14:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rycee rycee Awaiting requested review from rycee

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@timokau