Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ion: 1.0.5 -> unstable-2020-03-22 and fix build #83542

Merged
merged 1 commit into from
Mar 28, 2020
Merged

ion: 1.0.5 -> unstable-2020-03-22 and fix build #83542

merged 1 commit into from
Mar 28, 2020

Conversation

bhipple
Copy link
Contributor

@bhipple bhipple commented Mar 27, 2020

The app is still maintained upstream, but they aren't cutting releases on
crates.io anymore:
https://crates.io/crates/ion-shell

This fixes the build with the latest Rust toolchain by upgrading to the current
commit off the project's master.

ZHF: #80379

CC @NixOS/nixos-release-managers

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@bhipple
Copy link
Contributor Author

bhipple commented Mar 27, 2020 

λ brh nixpkgs →  ./result/bin/ion
ion: creating history file at "/home/bhipple/.local/share/ion/history"
bhipple:~/src/nixpkgs# ls
COPYING  default.nix  doc  flake.nix  lib  maintainers  nixos  pkgs  README.md  result
bhipple:~/src/nixpkgs#

Seems to work to me.

bhipple
bhipple commented Mar 27, 2020
View reviewed changes
pkgs/shells/ion/default.nix
license = licenses.mit;
maintainers = with maintainers; [ dywedir ];
platforms = platforms.all;
# This has not had a release since 2017, and no longer compiles with the
# latest Rust compiler.
broken = false;
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was supposed to say broken = true;, but at any rate now it's actually not broken :)

@ofborg ofborg bot requested a review from dywedir March 27, 2020 23:42
@bhipple
ion: 1.0.5 -> unstable-2020-03-22
16cdff0 
The app is still maintained upstream, but they aren't cutting releases on
crates.io anymore:
https://crates.io/crates/ion-shell

This fixes the build with the latest Rust toolchain by upgrading to the current
commit off the project's `master`.

ZHF: NixOS#80379
@bhipple bhipple mentioned this pull request Mar 28, 2020
Merged
@worldofpeace worldofpeace merged commit eddc4f3 into NixOS:master Mar 28, 2020
@bhipple bhipple deleted the zhf/ion branch June 2, 2020 22:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dywedir dywedir Awaiting requested review from dywedir

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@bhipple @worldofpeace