nixos/nixpkgs/lib/strings: add stringToValidNixPath #83223
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When using tools like nixpkgs.lib.attrsets.mapAttrsToList and trying to build derivations where nix store file names are to be created, set attributes like ".stack/config.yml" are invalid, so stringToValidNixPath cleans them up to allow them to be created in the nix store.
Mic92
reviewed
Mar 23, 2020
ofborg
bot
added
10.rebuild-darwin: 0
|
@infinisil If that's better than this, then by all means go for it. Or if you think I could adjust this to incorporate some of your concerns, like length, then I'm happy to update this (with your guidance) and accomplish the same goal |
rpearce
commented
Mar 23, 2020
|
|
||
| sanitizeNixPath = prefix: path: | ||
| let | ||
| safePrefix = if replaceStrings [" "] [""] prefix == "" then "safePrefix_" else prefix; |
There was a problem hiding this comment.
Should prefixing be left to consumers to figure out themselves?
|
I'm obviously biased towards my solution :). Some arguments for my solution are that it uses regex-based replacement, which should be faster than |
|
@infinisil If you get that into a PR, I'll test it out for you with what I'm testing with on my side, and if we get that to 👍, I'll close this. How does that sound? |
2 tasks
|
Done that :) #83241 |
Janik-Haag
added
the
12. first-time contribution
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(This is my first time contributing like this to nixpkgs... please be gentle)
Motivation for this change
When using tools like
nixpkgs.lib.attrsets.mapAttrsToListand trying to build derivations where nix store file names
are to be created, set attributes like
".stack/config.yml"are invalid, so
sanitizeNixPathcleans them up to allowthem to be created in the nix store.
I did not include
-as a valid character because of rycee's reasoning here.If no prefix is provided, the string
safePrefix_is used.Things done
strings.sanitizeNixPathstrings.sanitizeNixPathsandboxinnix.confon non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"./result/bin/)nix path-info -Sbefore and after)I'm not sure how to run the tests locally and could use some help doing that.