Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ghc-8.8.3: really use ld.gold (port #80466) #81318

Merged
merged 1 commit into from
Feb 28, 2020
Merged

ghc-8.8.3: really use ld.gold (port #80466) #81318

merged 1 commit into from
Feb 28, 2020

Conversation

ggreif
Copy link
Contributor

@ggreif ggreif commented Feb 28, 2020 •
edited
Loading

Motivation for this change

Bring 8.8.3 up to date

@peti

Things done

Ported 9a5ecf1.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ggreif ggreif requested a review from cdepillabout as a code owner February 28, 2020 20:19
@domenkozar domenkozar changed the base branch from haskell-updates to master February 28, 2020 20:22
@domenkozar domenkozar merged commit 00bd957 into NixOS:master Feb 28, 2020
@ggreif
Copy link
Contributor Author

ggreif commented Feb 28, 2020

@GrahamcOfBorg build haskell.packages.ghc883.lens

@ggreif
Copy link
Contributor Author

ggreif commented Feb 28, 2020

@GrahamcOfBorg build haskell.packages.ghc883.comonad

@domenkozar domenkozar mentioned this pull request Feb 29, 2020
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@cdepillabout cdepillabout Awaiting requested review from cdepillabout

Assignees
No one assigned
Labels
6.topic: haskell
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@ggreif @cdepillabout @domenkozar