Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

crystal: 0.32.1 -> 0.33.0 #80390

Closed
wants to merge 3 commits into from
Closed

crystal: 0.32.1 -> 0.33.0 #80390

wants to merge 3 commits into from

Conversation

Br1ght0ne
Copy link
Member

@Br1ght0ne Br1ght0ne commented Feb 18, 2020 •
edited
Loading

Motivation for this change

ZHF: #80379
Can't be backported to 20.03 because of feature freeze (0.32.1 build for 20.03 handled in #80389)

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

This change is Reviewable

@ofborg ofborg bot requested review from peterhoeg, manveru and david50407 February 18, 2020 00:16
@Br1ght0ne Br1ght0ne mentioned this pull request Feb 18, 2020
Merged
1 task
@Br1ght0ne Br1ght0ne force-pushed the crystal-0.33.0 branch 2 times, most recently from 7c9d724 to 525129e Compare February 18, 2020 00:45
@Br1ght0ne Br1ght0ne marked this pull request as ready for review February 18, 2020 00:46
@Br1ght0ne
Copy link
Member Author

Br1ght0ne commented Feb 18, 2020 •
edited
Loading

Sorry, accidentally committed a (now revoked) secret.

@Br1ght0ne
Copy link
Member Author

Br1ght0ne commented Feb 18, 2020 •
edited
Loading

Skipped a broken test, see crystal-lang/crystal#7925
@GrahamcOfBorg build crystal

lukateras
lukateras approved these changes Feb 21, 2020
View reviewed changes
Copy link
Member

@lukateras lukateras left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Builds, compiler is working.

pkgs/development/compilers/crystal/default.nix
@@ -102,6 +98,8 @@ let

makeFlags = [
"CRYSTAL_CONFIG_VERSION=${version}"
# FIXME: not sure if this is the best idea
Copy link
Member

@lukateras lukateras Feb 21, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why not? LGTM. The alternative is to set a writable HOME.

pkgs/development/compilers/crystal/default.nix Outdated Show resolved Hide resolved
@ofborg ofborg bot added the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 23, 2020
@ofborg ofborg bot removed the 2.status: merge conflict This PR has merge conflicts with the target branch label Feb 23, 2020
@lukateras
Copy link
Member

lukateras commented Feb 23, 2020 •
edited
Loading

Will merge on Feb 25 12 pm UTC unless anyone minds otherwise.

@lukateras
Copy link
Member

@GrahamcOfBorg build crystal_0_32

@lukateras
Copy link
Member

Unfortunately, looks like changes to generic break crystal_0_32_0 build :(

@lukateras lukateras self-requested a review February 27, 2020 03:58
@peterhoeg
Copy link
Member

Superseded by #85432

@peterhoeg peterhoeg closed this Apr 19, 2020
@Br1ght0ne Br1ght0ne deleted the crystal-0.33.0 branch April 23, 2020 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

@manveru manveru Awaiting requested review from manveru

@david50407 david50407 Awaiting requested review from david50407

@lukateras lukateras Awaiting requested review from lukateras

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Br1ght0ne @lukateras @peterhoeg