Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python/aiohttp: disable test on 32bit platforms #80388

Merged
merged 1 commit into from
Feb 18, 2020

Conversation

rnhmjoj
Copy link
Contributor

@rnhmjoj rnhmjoj commented Feb 17, 2020

Motivation for this change

The test test_cookiejar is failing because a time_t constant can't be represented on 32bit platforms. This is causing failures of all nixos tests on i686-linux.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

The test `test_cookiejar` is failing because a time_t
constant can't be represented on 32bit platforms.
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 18, 2020

@GrahamcOfBorg test login

@jonringer jonringer merged commit 6be8389 into NixOS:master Feb 18, 2020
@worldofpeace
Copy link
Contributor

ZHF: #80379

@worldofpeace
Copy link
Contributor

@jonringer This couldn't even been CI'd by ofborg because it's on i686-linux.
I'm currently building this with

nix-build -A python3Packages.aiohttp --option system i686-linux

@jonringer
Copy link
Contributor

merged based on diff, disabling a test is pretty harmless.

@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 18, 2020

Did you see if the NixOS test succeed? ofBorg apparently skipped i686-linux.

@jonringer
Copy link
Contributor

the x86_64 test did succeed https://github.com/NixOS/nixpkgs/runs/451651746

@worldofpeace
Copy link
Contributor

Did you see if the NixOS test succeed? ofBorg apparently skipped i686-linux.

Yeah doing that now. It is pretty harmless though, but it's to make the nixosTests succeed on i686-linux. Will backport for #80379 once I've confirmed.

@jonringer
Copy link
Contributor

ofborg only runs aarch64 and x86_64 with the test command, we could do ofborg build pkgsi686Linux.nixosTests.login to verify

@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 18, 2020

ofborg build pkgsi686Linux.nixosTests.login

Ooh that's pretty cool.

@jonringer
Copy link
Contributor

[234 built (11 failed), 441 copied (1885.1 MiB), 307.5 MiB DL]
error: build of '/nix/store/liwvgldjkz9571mqpfjx2v748sbgf8zd-env.drv' failed
https://github.com/NixOS/nixpkgs/pull/80388
3 package marked as broken and skipped:
bareos bonfire python37Packages.mailman-web

1 package blacklisted:
tests.nixos-functions.nixosTest-test

14 package failed to build:
ape ceph ceph-client datasette electrum fluidasserts libceph mailman-web python37Packages.hyperkitty python37Packages.pyatv python37Packages.sunpy sambaFull stig topydo

180 package built:
appdaemon aws-sam-cli azure-cli buku cookiecutter doh-proxy errbot fava flexget gdbgui git-revise glasgow gns3-server home-assistant home-assistant-cli lexicon mautrix-telegram mnemosyne pantalaimon poezio prometheus-xmpp-alerts python37Packages.Nikola python37Packages.aiohttp python37Packages.aiohttp-cors python37Packages.aiohttp-jinja2 python37Packages.aiohttp-remotes python37Packages.aiohttp-socks python37Packages.aiohttp-swagger python37Packages.aiohue python37Packages.aioresponses python37Packages.aiounifi python37Packages.aresponses python37Packages.arrow python37Packages.azure-applicationinsights python37Packages.azure-batch python37Packages.azure-core python37Packages.azure-eventgrid python37Packages.azure-functions-devops-build python37Packages.azure-graphrbac python37Packages.azure-identity python37Packages.azure-keyvault python37Packages.azure-keyvault-keys python37Packages.azure-keyvault-secrets python37Packages.azure-loganalytics python37Packages.azure-mgmt-advisor python37Packages.azure-mgmt-apimanagement python37Packages.azure-mgmt-appconfiguration python37Packages.azure-mgmt-applicationinsights python37Packages.azure-mgmt-authorization python37Packages.azure-mgmt-batch python37Packages.azure-mgmt-batchai python37Packages.azure-mgmt-billing python37Packages.azure-mgmt-botservice python37Packages.azure-mgmt-cdn python37Packages.azure-mgmt-cognitiveservices python37Packages.azure-mgmt-commerce python37Packages.azure-mgmt-common python37Packages.azure-mgmt-compute python37Packages.azure-mgmt-consumption python37Packages.azure-mgmt-containerinstance python37Packages.azure-mgmt-containerregistry python37Packages.azure-mgmt-containerservice python37Packages.azure-mgmt-cosmosdb python37Packages.azure-mgmt-datafactory python37Packages.azure-mgmt-datalake-analytics python37Packages.azure-mgmt-datalake-store python37Packages.azure-mgmt-datamigration python37Packages.azure-mgmt-deploymentmanager python37Packages.azure-mgmt-devspaces python37Packages.azure-mgmt-devtestlabs python37Packages.azure-mgmt-dns python37Packages.azure-mgmt-eventgrid python37Packages.azure-mgmt-eventhub python37Packages.azure-mgmt-hanaonazure python37Packages.azure-mgmt-hdinsight python37Packages.azure-mgmt-imagebuilder python37Packages.azure-mgmt-iotcentral python37Packages.azure-mgmt-iothub python37Packages.azure-mgmt-iothubprovisioningservices python37Packages.azure-mgmt-keyvault python37Packages.azure-mgmt-kusto python37Packages.azure-mgmt-loganalytics python37Packages.azure-mgmt-logic python37Packages.azure-mgmt-machinelearningcompute python37Packages.azure-mgmt-managedservices python37Packages.azure-mgmt-managementgroups python37Packages.azure-mgmt-managementpartner python37Packages.azure-mgmt-maps python37Packages.azure-mgmt-marketplaceordering python37Packages.azure-mgmt-media python37Packages.azure-mgmt-monitor python37Packages.azure-mgmt-msi python37Packages.azure-mgmt-netapp python37Packages.azure-mgmt-network python37Packages.azure-mgmt-notificationhubs python37Packages.azure-mgmt-policyinsights python37Packages.azure-mgmt-powerbiembedded python37Packages.azure-mgmt-privatedns python37Packages.azure-mgmt-rdbms python37Packages.azure-mgmt-recoveryservices python37Packages.azure-mgmt-recoveryservicesbackup python37Packages.azure-mgmt-redis python37Packages.azure-mgmt-relay python37Packages.azure-mgmt-reservations python37Packages.azure-mgmt-resource python37Packages.azure-mgmt-scheduler python37Packages.azure-mgmt-search python37Packages.azure-mgmt-security python37Packages.azure-mgmt-servicebus python37Packages.azure-mgmt-servicefabric python37Packages.azure-mgmt-signalr python37Packages.azure-mgmt-sql python37Packages.azure-mgmt-sqlvirtualmachine python37Packages.azure-mgmt-storage python37Packages.azure-mgmt-subscription python37Packages.azure-mgmt-trafficmanager python37Packages.azure-mgmt-web python37Packages.azure-multiapi-storage python37Packages.azure-servicebus python37Packages.azure-servicefabric python37Packages.azure-storage-file-share python37Packages.backports_functools_lru_cache python37Packages.black python37Packages.cheroot python37Packages.cherrypy python37Packages.connexion python37Packages.discordpy python37Packages.django-q python37Packages.entrance python37Packages.entrance-with-router-features python37Packages.flask-socketio python37Packages.hass-nabucasa python37Packages.ics python37Packages.irc python37Packages.jaraco_collections python37Packages.jaraco_functools python37Packages.jaraco_logging python37Packages.jaraco_text python37Packages.jinja2_time python37Packages.jsonrpc-async python37Packages.jsonrpc-websocket python37Packages.luftdaten python37Packages.matrix-nio python37Packages.mautrix python37Packages.mesa python37Packages.msrest python37Packages.msrestazure python37Packages.parfive python37Packages.plexauth python37Packages.plexwebsocket python37Packages.portend python37Packages.pyalgotrade python37Packages.pyhaversion python37Packages.pyls-black python37Packages.pytest-aiohttp python37Packages.pytest-black python37Packages.pytest-sanic python37Packages.python-engineio python37Packages.python-socketio python37Packages.rainbowstream python37Packages.sanic python37Packages.sanic-auth python37Packages.sentry-sdk python37Packages.slixmpp python37Packages.snitun python37Packages.stravalib python37Packages.stumpy python37Packages.tempora python37Packages.uarray python37Packages.vsts python37Packages.vsts-cd-manager python37Packages.ws4py python37Packages.zeep python37Packages.zerobin python37Packages.zha-quirks python37Packages.zigpy python37Packages.zigpy-deconz rapid-photo-downloader tribler watson

@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 18, 2020

The package builds on i686-linux, but the amount of things to build for the nixosTest would take hours 🤣

@worldofpeace
Copy link
Contributor

backported in 5c4224e

@worldofpeace worldofpeace added the 8.has: port to stable A PR already has a backport to the stable release. label Feb 18, 2020
@rnhmjoj
Copy link
Contributor Author

rnhmjoj commented Feb 18, 2020

The package builds on i686-linux, but the amount of things to build for the nixosTest would take hours 🤣

We'll wait for the next evaluation then.

@jonringer
Copy link
Contributor

nix-build ./nixpkgs/ -A pkgsi686Linux.nixosTests.login && echo passed
...
(8.01 seconds)
(8.01 seconds)
(110.29 seconds)
6 out of 6 tests succeeded
test script finished in 110.29s
cleaning up
(0.00 seconds)
/nix/store/pgkk6awfw7iki4ff5bcdd53h8lhcd3xc-vm-test-run-login
passed

@jonringer
Copy link
Contributor

it's at least passing locally for me

@rnhmjoj rnhmjoj deleted the aiohttp branch April 7, 2020 12:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants