Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

glibc: use python3Minimal instead of python3 #80112

Merged
merged 2 commits into from
Feb 15, 2020
Merged

glibc: use python3Minimal instead of python3 #80112

merged 2 commits into from
Feb 15, 2020

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Feb 14, 2020

Motivation for this change

Improve the speed of bootstrapping process.

I'm sorry I haven't noticed this attribute sooner.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS (x86_64 and aarch64)
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Confirmed zero impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
glibc: use python3Minimal instead of python3
f651910 
This should improve the speed of bootstrapping process.
Cost of evaluation also decreases a bit,
but I don't expect that will be significant.
@vcunat
openssl: revert a workaround that's no longer needed
5a8000d 
Thanks to python3Minimal.  This reverts part of c203848 NixOS#79738.
@vcunat vcunat mentioned this pull request Feb 14, 2020
Closed
@FRidh FRidh added this to the 20.03 milestone Feb 14, 2020
@FRidh FRidh added the 1.severity: channel blocker Blocks a channel label Feb 14, 2020
@ofborg ofborg bot added the 10.rebuild-linux-stdenv This PR causes stdenv to rebuild label Feb 14, 2020
@ofborg ofborg bot requested review from peti and edolstra February 14, 2020 12:55
@worldofpeace
Copy link
Contributor

worldofpeace commented Feb 14, 2020 •
edited
Loading

Yes thank you, I'm certain of this being backported 👍

@Ma27 Ma27 requested a review from lblasc February 14, 2020 20:46
@worldofpeace worldofpeace merged commit 1083046 into NixOS:staging Feb 15, 2020
@worldofpeace
Copy link
Contributor

backported in ced2b5a 306d76f

@vcunat vcunat deleted the p/glibc-python branch February 15, 2020 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ma27 Ma27 Ma27 approved these changes

@lblasc lblasc lblasc approved these changes

@peti peti Awaiting requested review from peti

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
1.severity: channel blocker Blocks a channel 10.rebuild-darwin: 11-100 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ 10.rebuild-linux-stdenv This PR causes stdenv to rebuild
Projects
Staging
Archived in project
Milestone
20.03
Development

Successfully merging this pull request may close these issues.
5 participants
@vcunat @worldofpeace @lblasc @Ma27 @FRidh