-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
treewide: change fetchCargoTarball default to opt-out #79978
Conversation
There are no manual changes in this PR; the diff is generated with the following script, which you're welcome to review in addition to the actual diff: In order to check for diffs, this script can be run to build a number of packages on master and then again after running the above script: Current output looks like this:
I've reviewed the diff as well and the rest of them look cookie-cutter, but if there's any one you're suspicious of let me know and I will verify that this PR does not change its hash or cause any rebuilds. |
@GrahamcOfBorg build ripgrep nix-du @GrahamcOfBorg eval |
@@ -17,7 +17,7 @@ | |||
# Please set to true on any Rust package updates. Once all packages set this | |||
# to true, we will delete and make it the default. For details, see the Rust | |||
# section on the manual and ./README.md. | |||
, legacyCargoFetcher ? true | |||
, legacyCargoFetcher ? false |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is the actual change on the PR. Once merged I'll send another one updating the manual and deleting this doc comment.
Since the PR is so big and likely to generate merge conflicts as others submit PRs bumping Rust applications, for now I've just stuck to a diff that can be programmatically regenerated after a hard reset to origin/master, though I could make the sed smarter.
Nice to see ofborg agrees this causes 0 rebuilds :) CC @worldofpeace @disassembler once merged I'll backport this to 20.03, but doing so requires #79981 first (which has the implementation, defaulted to false, and the removeAttrs fixes to allow this PR to be a clean no-rebuild change). |
I approved it, but I will defer integration to those who are informed. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
there are several merge conflicts, it would probably be prudent to get this in ASAP |
I believe it was mentioned the diff can be programmatically regenerated #79978 (comment) |
c6c2fc4
to
db33314
Compare
Did a I also re-ran the |
Changes the default fetcher in the Rust Platform to be the newer `fetchCargoTarball`, and changes every application using the current default to instead opt out. This commit does not change any hashes or cause any rebuilds. Once integrated, we will start deleting the opt-outs and recomputing hashes. See NixOS#79975 for details.
db33314
to
ade9c4b
Compare
Went into conflict again; rebase and re-regenerated the diff again :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
changes seems to be in anticipation to changes in the rust ecosystem.
LGTM
Changes the default fetcher in the Rust Platform to be the newer
fetchCargoTarball
, and changes every application using the current default toinstead opt out.
This commit does not change any hashes or cause any rebuilds. Once integrated,
we will start deleting the opt-outs and recomputing hashes.
See #79975 for details.
Things done
sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)