Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages/ssb-room: init at 1.1.2 #78037

Closed
wants to merge 1 commit into from
Closed

nodePackages/ssb-room: init at 1.1.2 #78037

wants to merge 1 commit into from

Conversation

asymmetric
Copy link
Contributor

@asymmetric asymmetric commented Jan 19, 2020 •
edited
Loading

Motivation for this change

Add ssb-room package.

Things done

Ran the ./generate.sh script after adding the package to node-packages-v10.json.

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.

/cc @NinjaTrappeur

asymmetric
asymmetric commented Jan 19, 2020
View reviewed changes
pkgs/development/node-packages/composition-v13.nix
@@ -2,7 +2,7 @@

{pkgs ? import <nixpkgs> {
inherit system;
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-13_x"}:
}, system ? builtins.currentSystem, nodejs ? pkgs."nodejs-8_x"}:
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not sure why this got changed.

Copy link
Member

@picnoir picnoir Jan 19, 2020 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

node2nix is called with the --node-js-13 argument https://github.com/NixOS/nixpkgs/blob/master/pkgs/development/node-packages/generate.sh#L10, which according to https://github.com/svanderburg/node2nix/blob/master/bin/node2nix.js#L134 is not implemented yet...

@marsam did you created this file manually? Is anything special preventing us to upstream that to node2nix?

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a proper issue to track that: #78044

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Created a proper issue to track that: #78044

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@marsam did you created this file manually?

yes, I remember changing this line with 13_x. Sorry about that!

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry about that!

No problem :) Let's fix this 👍

asymmetric
asymmetric commented Jan 19, 2020
View reviewed changes
pkgs/development/node-packages/node-env.nix
@@ -363,7 +363,7 @@ let

npm ${forceOfflineFlag} --nodedir=${nodeSources} ${npmFlags} ${stdenv.lib.optionalString production "--production"} rebuild

if [ "''${dontNpmInstall-}" != "1" ]
if [ "$dontNpmInstall" != "1" ]
Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nor this.

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This comes from a tree-wide change: 2811b03

It is to be expected.

@Ericson2314, this file has been auto-generated, should we upstream that to https://github.com/svanderburg/node2nix/blob/master/nix/node-env.nix#L366 ?

@prusnak
Copy link
Member

prusnak commented May 30, 2020

Please rework your PR. It now has a merge conflict after PR #89184 has been merged

@prusnak prusnak added 2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs labels May 30, 2020
@asymmetric
Copy link
Contributor Author

Closing, as I ended up not using this.

@asymmetric asymmetric closed this May 30, 2020
@picnoir
Copy link
Member

picnoir commented May 30, 2020

If somebody want to take over this at some point: the ground work in node2nix has been done. More infos on #78044

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@picnoir picnoir picnoir left review comments

@marsam marsam marsam left review comments

Assignees
No one assigned
Labels
2.status: merge conflict This PR has merge conflicts with the target branch 6.topic: nodejs 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@asymmetric @prusnak @picnoir @marsam