Merge pull request #77772 from x123/x123-add-qt-wrap-xygrib #77772
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
XyGrib does not currently work on
19.09.1840.f7d050ed4e3
without Qt, this type of behavior was also addressed in a larger pull request #54525Things done
Added
wrapQtAppsHook
to thexygrib
derivation and also ensured the output binary has a sensible lowercased name rather than some silly camelcase thing (xygrib and zygrib have never actually used CamelCased names on any other distributions I'm familiar with).sandbox
innix.conf
on non-NixOS linux)nix-shell -p nixpkgs-review --run "nixpkgs-review wip"
./result/bin/
)nix path-info -S
before and after)