stdenv: make darwin builds reproducable #77632

LnL7 · 2020-01-13T17:09:10Z

Motivation for this change

Here's an example using hello (without the stdenv changes) https://gist.github.com/LnL7/7e705ea7f4099c074a004c897810bc73

And a run of r13y over the darwin stdenv
https://dgn9s9wft3u6a.cloudfront.net/store/ppm2pvkw1ngvmw063qbkxsg7r0nvdcxi-report/index.html

Things done

/cc @NixOS/darwin-maintainers

tobim

According to https://cmake.org/cmake/help/latest/variable/CMAKE_OSX_DEPLOYMENT_TARGET.html
the CMAKE_OSX_DEPLOYMENT_TARGET will be initialized from MACOSX_DEPLOYMENT_TARGET, so it should be safe to remove those flags from the affected packages.

tobim · 2020-01-14T10:54:45Z

pkgs/os-specific/darwin/apple-sdk/default.nix

+let version = "10.12"; in
+
+# Ensure appleSdkVersion is up to date.
+assert stdenv.isDarwin -> stdenv.appleSdkVersion == version;


Why don't we just use stdenv.appleSdkVersion?

The attribute is macOS specific, without the condition evaluating darwin only packages on linux fails on the assertion instead of meta.platforms with a nice message.

What I was trying to ask is: if version must be equal to stdenv.appleSdkVersion, then why is one of them not initialized from the other, as in version = stdenv.appleSdkVersion or "invalid platform";?

LnL7 · 2020-01-14T11:06:08Z

Indeed, but it's explicitly disabled for some reason.

@matthewbauer Why did you disabled the deployment target for cmake 8beb809? We do want binaries to have a minimum version.

tobim · 2020-01-14T12:45:22Z

libuv fails on 1 test (was on 1eed714):

not ok 42 - fs_event_error_reporting
# exit code 11
# Output from process `fs_event_error_reporting`:
# 2020-01-14 12:38 run-tests[62081] (FSEvents.framework) FSEventStreamStart: register_with_server: ERROR: f2d_register_rpc() => (null) (-21)

pkgs/development/interpreters/erlang/R19.nix

matthewbauer · 2020-01-14T15:42:45Z

pkgs/development/tools/build-managers/cmake/setup-hook.sh

    # we never want to use the global macOS SDK
    cmakeFlags="-DCMAKE_OSX_SYSROOT= $cmakeFlags"

-    # disable OSX deployment target
-    # we don't want our binaries to have a "minimum" OSX version
-    cmakeFlags="-DCMAKE_OSX_DEPLOYMENT_TARGET= $cmakeFlags"


I'm surprised this isn't needed? How does CMake choose this value when it's unset?

If not set explicitly the value is initialized by the MACOSX_DEPLOYMENT_TARGET environment variable, if set, and otherwise computed based on the host platform.

So if I understand this correctly this was equivalent to unsetting MACOSX_DEPLOYMENT_TARGET from the stdenv.

matthewbauer · 2020-01-14T15:44:07Z

pkgs/stdenv/darwin/default.nix

+
+    # Ensure consistent LC_VERSION_MIN_MACOSX and remove LC_UUID.
+    export MACOSX_DEPLOYMENT_TARGET=${macosVersionMin}
+    export NIX_LDFLAGS+=" -macosx_version_min ${macosVersionMin} -sdk_version ${appleSdkVersion} -no_uuid"


I'm not sure how the linker works when you pass multiple values here. For instance, is -macosx_version_min 10.12 -macosx_version_min 10.14 a valid argument list?

MACOSX_DEPLOYMENT_TARGET and -macos_version_min are closely related but not the same. AFAIK the variable is used by build systems and headers for version specific pragmas while the linker flag just configures the load command.

Alltho since it looks like the compiler always adds the flag based on the variable, overriding this original one, it's not really necessary. Added it just in case but should be fine to leave out if you're concerned about it.

matthewbauer · 2020-01-14T15:45:08Z

pkgs/stdenv/darwin/default.nix

    # Workaround for https://openradar.appspot.com/22671534 on 10.11.
    export gl_cv_func_getcwd_abort_bug=no
+
+    stripAllFlags=" " # the Darwin "strip" command doesn't know "-s"


Making this a space is kind of hacky, but I think it is because of the - in ${stripAllFlags:--s} in setup.sh?

Yeah, but doesn't that do the opposite of what we want here?

Docs say that :- means:

If parameter is unset or null, the expansion of word is substituted. Otherwise, the value of parameter is substituted.

So yeah it sounds like the space is needed

LnL7 · 2020-01-15T10:05:41Z

@tobim libuv builds fine here

LnL7 · 2020-01-15T10:20:50Z

Looks like anything that links against impure system frameworks still isn't reproducable, but that's somewhat to be expected.

-/nix/store/1nkad14ypnqhlwn4w4rs287679y09ly3-libuv-1.34.0/lib/libuv.1.dylib:
+/nix/store/hywq7d7bmql8a1w0m28y59pim76dldav-libuv-1.34.0/lib/libuv.1.dylib:
 Load command 0
       cmd LC_SEGMENT_64
   cmdsize 552
@@ -260,7 +260,7 @@
       cmdsize 104
          name /System/Library/Frameworks/CoreFoundation.framework/Versions/A/CoreFoundation (offset 24)
    time stamp 2 Thu Jan  1 01:00:02 1970
-      current version 1575.23.0
+      current version 1349.8.0
 compatibility version 150.0.0
 Load command 11
           cmd LC_RPATH

I've thought before about doing the same as Libsystem for all impure libraries we interact with, also solving some sandboxing problems, but that would be quite hard to maintain.

LnL7 · 2020-01-31T07:58:13Z

Unless anybody has concerns I'm going to merge this soon.

tobim · 2020-01-31T11:37:26Z

@tobim libuv builds fine here

The build failure on my machine is gone now too.

Fixes NixOS#21629 Passing these extra linker flags removes both the semi-random uuid included in most binaries as well as making the sdk version consistent instead of based on the current os version. Load command 8 cmd LC_UUID cmdsize 24 uuid 70FAF921-5DC8-371C-B814-4F121FADFDF4 Load command 9 cmd LC_VERSION_MIN_MACOSX cmdsize 16 version 10.12 sdk 10.13 The -macosx_version_min flag isn't strictly necessary since that's already handled by MACOSX_DEPLOYMENT_TARGET.

We _do_ want minimum versions in our packages.

This was initially introduced in 92188d9, not clear how relevant this still is but i686 isn't supported anymore so disable it explicitly.

primeos · 2020-08-08T17:55:08Z

FYI: Due to regressions in CMake 3.18, CMAKE_OSX_ARCHITECTURES=x86_64 now causes problems for Linux builds. I've opened #94952 to see if it makes sense to set this only on Darwin, but I'm not familiar with the details and reasons here (maybe we want a unified set of flags for all platforms?). Feel free to voice your opinion in #94952 if you have time for a quick look. Thanks :)

FRidh added 6.topic: darwin Running or building packages on Darwin 6.topic: reproducible builds 6.topic: stdenv Standard environment labels Jan 13, 2020

ofborg bot added the 6.topic: erlang label Jan 14, 2020

LnL7 force-pushed the darwin-macos-version-min branch from 75c2904 to 1eed714 Compare January 14, 2020 10:26

LnL7 changed the title ~~[WIP] stdenv: make darwin builds reproducable~~ stdenv: make darwin builds reproducable Jan 14, 2020

ofborg bot added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Jan 14, 2020

ofborg bot requested review from tobim and Mic92 January 14, 2020 10:45

ofborg bot added 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-linux: 11-100 labels Jan 14, 2020

tobim suggested changes Jan 14, 2020

View reviewed changes

ofborg bot requested a review from tobim January 14, 2020 11:36

ofborg bot added 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+ and removed 10.rebuild-linux: 11-100 labels Jan 14, 2020

matthewbauer reviewed Jan 14, 2020

View reviewed changes

pkgs/development/interpreters/erlang/R19.nix Outdated Show resolved Hide resolved

matthewbauer reviewed Jan 14, 2020

View reviewed changes

LnL7 added 2 commits January 31, 2020 21:52

cmake: remove CMAKE_OSX_DEPLOYMENT_TARGET overrides

b984c22

We _do_ want minimum versions in our packages.

cmake: move CMAKE_OSX_ARCHITECTURES out of the stdenv

68513e4

This was initially introduced in 92188d9, not clear how relevant this still is but i686 isn't supported anymore so disable it explicitly.

LnL7 force-pushed the darwin-macos-version-min branch from ddc17f6 to 68513e4 Compare January 31, 2020 20:52

LnL7 requested review from FRidh, jonringer and ttuegel as code owners January 31, 2020 20:52

LnL7 changed the base branch from master to staging January 31, 2020 20:54

LnL7 merged commit 6f38c93 into NixOS:staging Jan 31, 2020

LnL7 deleted the darwin-macos-version-min branch January 31, 2020 21:34

marsam mentioned this pull request Feb 18, 2020

bazel broken on darwin #80440

Closed

eraserhd mentioned this pull request Feb 20, 2020

plan9port: fix linker flags for macosx #80603

Merged

10 tasks

mroi mentioned this pull request Feb 21, 2020

Darwin: cross compilation of glibc fails #80754

Closed

matthewbauer mentioned this pull request Mar 22, 2020

riscv64-none-elf-ld fails with "unrecognised emulation mode: acosx_version_min" on macOS #83141

Closed

primeos mentioned this pull request Aug 8, 2020

CMake: Set CMAKE_OSX_ only on Darwin? #94952

Closed

thefloweringash mentioned this pull request Feb 5, 2021

Darwin platform versions #111988

Merged

14 tasks

mstone mentioned this pull request Jun 20, 2022

darwin stdenv's ld -no_uuid linker flag breaks normal symbolication for debugging + profiling #178366

Closed

zhaofengli mentioned this pull request Aug 26, 2022

bintools-wrapper: Set ZERO_AR_DATE and re-enable LC_UUID on Darwin #188347

Merged

13 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

stdenv: make darwin builds reproducable #77632

stdenv: make darwin builds reproducable #77632

LnL7 commented Jan 13, 2020 •

edited

Loading

tobim left a comment

tobim Jan 14, 2020

LnL7 Jan 14, 2020

tobim Jan 19, 2020

LnL7 commented Jan 14, 2020 •

edited

Loading

tobim commented Jan 14, 2020

matthewbauer Jan 14, 2020

LnL7 Jan 14, 2020

matthewbauer Jan 14, 2020

LnL7 Jan 14, 2020

matthewbauer Jan 14, 2020

LnL7 Jan 14, 2020

matthewbauer Jan 14, 2020

LnL7 commented Jan 15, 2020

LnL7 commented Jan 15, 2020

LnL7 commented Jan 31, 2020

tobim commented Jan 31, 2020

primeos commented Aug 8, 2020

stdenv: make darwin builds reproducable #77632

stdenv: make darwin builds reproducable #77632

Conversation

LnL7 commented Jan 13, 2020 • edited Loading

Motivation for this change

Things done

tobim left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LnL7 commented Jan 14, 2020 • edited Loading

tobim commented Jan 14, 2020

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

LnL7 commented Jan 15, 2020

LnL7 commented Jan 15, 2020

LnL7 commented Jan 31, 2020

tobim commented Jan 31, 2020

primeos commented Aug 8, 2020

LnL7 commented Jan 13, 2020 •

edited

Loading

LnL7 commented Jan 14, 2020 •

edited

Loading