Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update qtbase mac patches for 5.12.6 #74911

Merged
merged 1 commit into from
Dec 3, 2019

Conversation

lavoiesl
Copy link
Contributor

@lavoiesl lavoiesl commented Dec 3, 2019

Motivation for this change

qtbase was updated to 5.12.6 in #73562, but the patch for macOS wasn't regenerated, causing the build to fail.

Fixes: #74770

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @dtzWill
cc @ttuegel
cc @Ericson2314
cc @vcunat

qtbase was updated to 5.12.6 in NixOS#73562,
but the patch for macOS wasn't regenerated, causing the build to fail.
@lavoiesl lavoiesl requested a review from ttuegel as a code owner December 3, 2019 12:45
@ofborg ofborg bot added 6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 3, 2019
@veprbl
Copy link
Member

veprbl commented Dec 3, 2019

@GrahamcOfBorg build qt5.qmake
@GrahamcOfBorg build qt5.qtbase
@GrahamcOfBorg build qt5.qtcharts
@GrahamcOfBorg build qt5.qtconnectivity
@GrahamcOfBorg build qt5.qtdeclarative
@GrahamcOfBorg build qt5.qtdoc
@GrahamcOfBorg build qt5.qtgraphicaleffects
@GrahamcOfBorg build qt5.qtimageformats
@GrahamcOfBorg build qt5.qtlocation
@GrahamcOfBorg build qt5.qtmacextras
@GrahamcOfBorg build qt5.qtmultimedia
@GrahamcOfBorg build qt5.qtquickcontrols
@GrahamcOfBorg build qt5.qtquickcontrols2
@GrahamcOfBorg build qt5.qtscript
@GrahamcOfBorg build qt5.qtsensors
@GrahamcOfBorg build qt5.qtserialport
@GrahamcOfBorg build qt5.qtsvg
@GrahamcOfBorg build qt5.qttools
@GrahamcOfBorg build qt5.qttranslations
@GrahamcOfBorg build qt5.qtvirtualkeyboard
@GrahamcOfBorg build qt5.qtwayland
@GrahamcOfBorg build qt5.qtwebchannel
@GrahamcOfBorg build qt5.qtwebengine
@GrahamcOfBorg build qt5.qtwebkit
@GrahamcOfBorg build qt5.qtwebsockets
@GrahamcOfBorg build qt5.qtx11extras
@GrahamcOfBorg build qt5.qtxmlpatterns

@veprbl veprbl merged commit f27b686 into NixOS:master Dec 3, 2019
@lavoiesl lavoiesl deleted the seb-qtbase-5.12.6-mac branch December 4, 2019 10:28
@collares collares mentioned this pull request Dec 31, 2020
16 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: qt/kde 10.rebuild-darwin: 101-500 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

qtbase darwin build failure
2 participants