Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nixos/ndppd: enable systemd sandboxing #74700

Merged
merged 1 commit into from
Jan 13, 2020
Merged

nixos/ndppd: enable systemd sandboxing #74700

merged 1 commit into from
Jan 13, 2020

Conversation

mmilata
Copy link
Member

@mmilata mmilata commented Nov 29, 2019

Adds some systemd sandboxing options to the service file. Seems to work fine for me, more testing is appreciated.

Motivation for this change

It's probably good for security to lock down network-facing services running under root as much as possible.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @gnidorah @elseym @fpletz

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Nov 29, 2019
@mmilata mmilata mentioned this pull request Nov 29, 2019
Closed
@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 29, 2019
@Ma27 Ma27 requested a review from elseym November 30, 2019 09:00
@mmilata mmilata mentioned this pull request Dec 11, 2019
Open
@elseym
Copy link
Member

elseym commented Jan 13, 2020 •
edited
Loading

sorry, somehow forgot about this pr.

lgtm but i am not yet a systemd expert. maybe @fpletz wants to take a look at this?

fpletz
fpletz approved these changes Jan 13, 2020
View reviewed changes
Copy link
Member

@fpletz fpletz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The ndppd NixOS test works and the options look reasonable for this service.

@fpletz fpletz merged commit d9319e8 into NixOS:master Jan 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fpletz fpletz fpletz approved these changes

@elseym elseym Awaiting requested review from elseym

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@mmilata @elseym @fpletz