Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

stage-1: create temporary secrets directory in /tmp and not in cwd #73780

Merged
merged 1 commit into from
Aug 17, 2021
Merged

stage-1: create temporary secrets directory in /tmp and not in cwd #73780

merged 1 commit into from
Aug 17, 2021

Conversation

h0m1
Copy link
Contributor

@h0m1 h0m1 commented Nov 19, 2019

Motivation for this change

nixos-rebuild boot/switch fails when executed from /nix/store and config.boot.initrd.secrets are used. Its because it creates a directory in the current working directory.

Fix for 73404

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS linux)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Ensured that relevant documentation is up to date
  • Fits CONTRIBUTING.md.
Notify maintainers

cc @

@ofborg ofborg bot added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Nov 19, 2019
@stale
Copy link

stale bot commented Jun 1, 2020

Thank you for your contributions.
This has been automatically marked as stale because it has had no activity for 180 days.
If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity.
Here are suggestions that might help resolve this more quickly:

  1. Search for maintainers and people that previously touched the
    related code and @ mention them in a comment.
  2. Ask on the NixOS Discourse. 3. Ask on the #nixos channel on
    irc.freenode.net.

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Jun 1, 2020
@jonringer
Copy link
Contributor

cc @Mic92 @samueldr

@stale stale bot removed the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Dec 8, 2020
@antifuchs
Copy link
Contributor

still important to me

0x4A6F
0x4A6F approved these changes Jan 3, 2021
View reviewed changes
Copy link
Member

@0x4A6F 0x4A6F left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Deployed systems (x86_64-linux) with nixos-rebuild, krops and deploy-rs with this change successfully.

@0x4A6F 0x4A6F mentioned this pull request Jan 3, 2021
Closed
@szlend
Copy link
Member

szlend commented Jan 17, 2021

I also tested this change with deploy-rs. Is there any chance of backporting this to 20.09? It seems like a pretty inconsequential fix to backport.

@tolbrino
Copy link
Contributor

👍 This fix would indeed be useful.

@stale
Copy link

stale bot commented Aug 17, 2021

I marked this as stale due to inactivity. → More info

@stale stale bot added the 2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md label Aug 17, 2021
@Mic92 Mic92 merged commit 4df4429 into NixOS:master Aug 17, 2021
@tolbrino
Copy link
Contributor

👍

@0x4A6F 0x4A6F mentioned this pull request Sep 1, 2021
Closed
@Janik-Haag Janik-Haag added the 12. first-time contribution This PR is the author's first one; please be gentle! label Jun 12, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@0x4A6F 0x4A6F 0x4A6F approved these changes

Assignees
No one assigned
Labels
2.status: stale https://github.com/NixOS/nixpkgs/blob/master/.github/STALE-BOT.md 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
8 participants
@h0m1 @jonringer @antifuchs @szlend @tolbrino @0x4A6F @Mic92 @Janik-Haag