Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Revert "ibus-packages.mozc: pin to protobuf 3.6" #60152

Merged
merged 1 commit into from
Apr 24, 2019
Merged

Revert "ibus-packages.mozc: pin to protobuf 3.6" #60152

merged 1 commit into from
Apr 24, 2019

Conversation

Lucus16
Copy link
Contributor

@Lucus16 Lucus16 commented Apr 24, 2019

Motivation for this change

protobuf was bumped to 3.7.1, which fixes the build issue as described
in google/mozc#460.

This reverts commit a19fbaf.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Lucus16
Revert "ibus-packages.mozc: pin to protobuf 3.6"
a5ed6ab 
protobuf was bumped to 3.7.1, which fixes the build issue as described
in google/mozc#460.

This reverts commit a19fbaf.
@Lucus16
Copy link
Contributor Author

Lucus16 commented Apr 24, 2019

@GrahamcOfBorg build ibus-engines.mozc

@ofborg ofborg bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 24, 2019
@teto
Copy link
Member

teto commented Apr 24, 2019

@GrahamcOfBorg build ibus-engines.mozc

@teto teto merged commit 65a9632 into NixOS:master Apr 24, 2019
@teto
Copy link
Member

teto commented Apr 24, 2019

thanks

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Lucus16 @teto