Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deepin.udisks2-qt5: init at 0.0.1 #59247

Merged
merged 2 commits into from
Apr 10, 2019
Merged

deepin.udisks2-qt5: init at 0.0.1 #59247

merged 2 commits into from
Apr 10, 2019

Conversation

romildo
Copy link
Contributor

@romildo romildo commented Apr 10, 2019

Motivation for this change

Add udisks2-qt5, UDisks2 D-Bus interfaces binding for Qt5.

About packaging deepin for NixOS: #59023

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@romildo
Copy link
Contributor Author

romildo commented Apr 10, 2019

It is a dependency for dde-file-manager.

@romildo romildo requested a review from worldofpeace April 10, 2019 04:08
@romildo
Copy link
Contributor Author

romildo commented Apr 10, 2019

@GrahamcOfBorg build deepin.udisks2-qt5

@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Apr 10, 2019
worldofpeace
worldofpeace approved these changes Apr 10, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixup commit added qtbase.

Other than that this looks fine 👍

@romildo romildo merged commit c5b633a into NixOS:master Apr 10, 2019
@romildo romildo deleted the upd.deepin.udisks2-qt5 branch April 10, 2019 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@romildo @worldofpeace @GrahamcOfBorg