Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

all-packages: try withing spliced packages. #58327

Closed
wants to merge 1 commit into from
Closed

all-packages: try withing spliced packages. #58327

wants to merge 1 commit into from

Conversation

Ericson2314
Copy link
Member

Motivation for this change

This is an experiment. On one hand, it should unbreak some cross things,
on the other, if inherit is used for things other than overriding it
will lead to "doubly spliced" packages, which is an insane mess.

CC @matthewbauer

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nix-review --run "nix-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Ericson2314
all-packages: try withing spliced packages.
b052b74 
This is an experiment. On one hand, it should unbreak some cross things,
on the other, if `inherit` is used for things other than overriding it
will lead to "doubly spliced" packages, which is an insane mess.
This was referenced Mar 26, 2019
Open
Closed
@infinisil
Copy link
Member

What's the status of this?

@Ericson2314
Copy link
Member Author

Ericson2314 commented Jan 16, 2020 •
edited
Loading

It's not the big win thought it was and breaks other things. I would rather not do this.

@infinisil
Copy link
Member

Closing then

@infinisil infinisil closed this Jan 16, 2020
@Ericson2314
Copy link
Member Author

Thanks!

@Ericson2314 Ericson2314 deleted the with-spliced-packages branch January 17, 2020 02:54
@Ericson2314 Ericson2314 mentioned this pull request Jun 8, 2020
Closed
10 tasks
@Artturin Artturin mentioned this pull request Dec 3, 2022
Open
@Artturin Artturin mentioned this pull request Nov 1, 2024
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer Awaiting requested review from matthewbauer

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@Ericson2314 @infinisil