Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gpgme: cross compilation #58046

Merged
merged 1 commit into from
Mar 22, 2019
Merged

gpgme: cross compilation #58046

merged 1 commit into from
Mar 22, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

Add cross compilation support for gpgme, this is important in cross-compiling NixOS itself, which I'm attempting to accomplish here: https://github.com/illegalprime/nixos-on-arm

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@illegalprime illegalprime mentioned this pull request Mar 21, 2019
Merged
10 tasks
@primeos primeos added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Mar 22, 2019
@primeos primeos self-assigned this Mar 22, 2019
primeos
primeos approved these changes Mar 22, 2019
View reviewed changes
Copy link
Member

@primeos primeos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks :)

@primeos primeos merged commit 69e23dc into NixOS:master Mar 22, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@primeos primeos primeos approved these changes

@Fuuzetsu Fuuzetsu Awaiting requested review from Fuuzetsu

Assignees

@primeos primeos

Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@illegalprime @primeos @GrahamcOfBorg