Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

flatpak: Fix bubblewrap paths for icon-validator #57889

Merged
merged 1 commit into from
Mar 19, 2019
Merged

flatpak: Fix bubblewrap paths for icon-validator #57889

merged 1 commit into from
Mar 19, 2019

Conversation

mat8913
Copy link
Contributor

@mat8913 mat8913 commented Mar 19, 2019

Motivation for this change

Otherwise, flatpak-validate-icon --sandbox gives error:

bwrap: Can't find source path /etc/ld.so.cache: No such file or directory
Things done

I use the same approach as in https://github.com/NixOS/nixpkgs/blob/e6ccb67e23bce78e152ddcd9a85b6a44651e276f/pkgs/desktops/gnome-3/core/gnome-desktop/bubblewrap-paths.patch

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@mat8913
flatpak: Fix bubblewrap paths for icon-validator
f2d6e4a 
Otherwise, `flatpak-validate-icon --sandbox` gives error:
  bwrap: Can't find source path /etc/ld.so.cache: No such file or directory
@GrahamcOfBorg GrahamcOfBorg requested a review from jtojnar March 19, 2019 05:18
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 19, 2019
@worldofpeace worldofpeace self-requested a review March 19, 2019 05:32
jtojnar
jtojnar approved these changes Mar 19, 2019
View reviewed changes
Copy link
Member

@jtojnar jtojnar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, thank you.

@jtojnar jtojnar merged commit f4ffeaf into NixOS:master Mar 19, 2019
@mat8913 mat8913 deleted the flatpak-bubblewrap-paths branch March 20, 2019 01:38
@mat8913
Copy link
Contributor Author

mat8913 commented Mar 21, 2019

Thanks for merging. Could this also be included in release-19.03?

@worldofpeace
Copy link
Contributor

Thanks for merging. Could this also be included in release-19.03?

backported in 6f2fc31

@mat8913 mat8913 mentioned this pull request Oct 9, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@worldofpeace worldofpeace Awaiting requested review from worldofpeace

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@mat8913 @worldofpeace @jtojnar @GrahamcOfBorg