Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

libassuan: use config flag to specify libgpg-error prefix #57815

Merged
merged 1 commit into from
Apr 16, 2019
Merged

libassuan: use config flag to specify libgpg-error prefix #57815

merged 1 commit into from
Apr 16, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

libgpgerror has a binary that gets called during build to retrieve path information. during cross compilation a buildPackages version of this will point to the wrong libs, but the normal version cannot be executed on the build machine. therefore we set it explicitly in the configure script.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@delroth
Copy link
Contributor

delroth commented Apr 6, 2019

Fixes a cross-build issue I was also hitting. Thanks!

@FRidh FRidh merged commit a7d2d7d into NixOS:master Apr 16, 2019
alyssais added a commit to alyssais/nixpkgs that referenced this pull request Feb 2, 2023
@alyssais
Revert "libassuan: Use automatically detected libgpg-error"
14d9512 
This reverts commit 2d44dc9.

Cross-compilation only works if we set --with-libgpg-error-prefix,
which is why that flag was there in the first place[1].  Unfortunately
this was not noted in the commit message that added it, which made it
difficult to discover…

[1]: NixOS#57815
@alyssais alyssais mentioned this pull request Feb 2, 2023
Merged
13 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 501-1000 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@illegalprime @delroth @matthewbauer @FRidh @GrahamcOfBorg