Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

wf-recorder: init at unstable-2019-03-12 #57662

Merged
merged 1 commit into from
Mar 16, 2019
Merged

wf-recorder: init at unstable-2019-03-12 #57662

merged 1 commit into from
Mar 16, 2019

Conversation

CrazedProgrammer
Copy link
Contributor

Motivation for this change

Adds wf-recorder, a program for making screen captures on wlroots-based compositors like Sway.

See also: #57602.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@CrazedProgrammer CrazedProgrammer force-pushed the wf-recorder branch 2 times, most recently from b474d63 to fa8d671 Compare March 14, 2019 22:02
@GrahamcOfBorg GrahamcOfBorg added 8.has: package (new) This PR adds a new package 11.by: package-maintainer This PR was created by the maintainer of the package it changes 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 14, 2019
ryantm
ryantm requested changes Mar 15, 2019
View reviewed changes
pkgs/applications/video/wf-recorder/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/wf-recorder/default.nix Outdated Show resolved Hide resolved
pkgs/applications/video/wf-recorder/default.nix Outdated Show resolved Hide resolved
@primeos primeos mentioned this pull request Mar 15, 2019
Open
22 tasks
@CrazedProgrammer CrazedProgrammer changed the title wf-recorder: init at 2019-03-12 wf-recorder: init at unstable-2019-03-12 Mar 16, 2019
@CrazedProgrammer
Copy link
Contributor Author

Thanks for reviewing @ryantm @jtojnar! I've made the suggested changes.

@ryantm
Copy link
Member

ryantm commented Mar 16, 2019

@GrahamcOfBorg build wf-recorder

@ryantm ryantm merged commit 96e4072 into NixOS:master Mar 16, 2019
@ryantm
Copy link
Member

ryantm commented Mar 16, 2019

Thanks!

@CrazedProgrammer CrazedProgrammer deleted the wf-recorder branch March 16, 2019 16:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar jtojnar approved these changes

@ryantm ryantm ryantm approved these changes

Assignees
No one assigned
Labels
8.has: package (new) This PR adds a new package 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@CrazedProgrammer @ryantm @jtojnar @GrahamcOfBorg