Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

sway: replace with sway-beta #57413

Closed
wants to merge 2 commits into from
Closed

sway: replace with sway-beta #57413

wants to merge 2 commits into from

Conversation

tadeokondrak
Copy link
Contributor

Motivation for this change

Sway is now out of beta, so sway-beta isn't needed anymore

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@tadeokondrak tadeokondrak requested a review from infinisil as a code owner March 11, 2019 16:37
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` labels Mar 11, 2019
@tadeokondrak
Copy link
Contributor Author

Closing in favour of package maintainer's #57414 (which has one less mistake, this has an extra period for mkenableoption)

@primeos
Copy link
Member

primeos commented Mar 11, 2019

@tadeokondrak sorry, I've got the mention from GrahamcOfBorg too late - I hope this is ok for you. I would not mind merging your PR but it's a bit more effort to review since I'm not sure what you've changed manually.

@GrahamcOfBorg GrahamcOfBorg requested a review from primeos March 11, 2019 16:54
@GrahamcOfBorg GrahamcOfBorg added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Mar 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil Awaiting requested review from infinisil

@primeos primeos Awaiting requested review from primeos

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: clean-up 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tadeokondrak @primeos @GrahamcOfBorg