Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

cmake: add ability to cross-compile cmake #56021

Merged
merged 1 commit into from
Feb 20, 2019
Merged

cmake: add ability to cross-compile cmake #56021

merged 1 commit into from
Feb 20, 2019

Conversation

illegalprime
Copy link
Member

Motivation for this change

Allows cmake to be cross-compiled, this does not make a cmake that runs on the build platform and generates code for a different architecture, but a cmake that runs on another architecture.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild label Feb 18, 2019
@matthewbauer matthewbauer changed the base branch from master to staging February 18, 2019 23:22
@GrahamcOfBorg GrahamcOfBorg added 6.topic: emacs Text editor 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: vim 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 18, 2019
@matthewbauer matthewbauer changed the base branch from staging to master February 19, 2019 01:38
@matthewbauer matthewbauer changed the base branch from master to staging February 19, 2019 01:38
@GrahamcOfBorg GrahamcOfBorg removed 6.topic: emacs Text editor 6.topic: fetch 6.topic: GNOME GNOME desktop environment and its underlying platform 6.topic: haskell 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 6.topic: python 6.topic: qt/kde 6.topic: vim labels Feb 19, 2019
@GrahamcOfBorg GrahamcOfBorg removed 8.has: documentation This PR adds or changes documentation 8.has: module (update) This PR changes an existing module in `nixos/` 2.status: merge conflict This PR has merge conflicts with the target branch labels Feb 19, 2019
@FRidh FRidh added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Feb 19, 2019
@matthewbauer matthewbauer merged commit ae3e835 into NixOS:staging Feb 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@LnL7 LnL7 Awaiting requested review from LnL7

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 501+ 10.rebuild-darwin: 5001+ 10.rebuild-darwin-stdenv This PR causes stdenv to rebuild 10.rebuild-linux: 501+ 10.rebuild-linux: 5001+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@illegalprime @matthewbauer @FRidh @GrahamcOfBorg