-
-
Notifications
You must be signed in to change notification settings - Fork 14.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
dydisnix: init at unstable #49366
dydisnix: init at unstable #49366
Conversation
Success on aarch64-linux (full log) Attempted: dydisnix Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: dydisnix Partial log (click to expand)
|
Interesting to see that there are people who want to use this package and integrate it into Nixpkgs! But, I want to raise a big warning: dydisnix is by far not as mature as the core toolset: disnix. It should not be considered as reliable or usable. For example: it lacks the same quality level in terms of documentation and code compared to the core package. Originally, the package was developed for a research paper under enormous time pressure. Moreover, dydisnix has no decent end-user documentation, aside from a simple README.md, and it has never been used for production deployments (at least not by me). Furthermore, I also have not made any commitments in providing stable interfaces of the APIs and command-line tools. Although I'm occasionally working on Disnix and the extensions, including dydisnix, it still requires some work and stabilization effort to create an initial 0.1 release. This is why I have not created any releases yet! I don't mind that this change gets integrated into Nixpkgs, but we somehow need to remind potential users that dydisnix is a highly experimental prototype that is subject to major changes! |
@svanderburg By the sound of it we should set |
@Synthetica9 Technically, the package is not broken, just not officially released or production ready :) |
updated with suggestions from @xeji
a9b72d3
to
f9d5e52
Compare
Success on x86_64-linux (full log) Attempted: dydisnix Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: dydisnix Partial log (click to expand)
|
(triage) @svanderburg Do you prefer this PR merged, not merged, merged with |
@tomberek Based on my reading of these comments, it seems fine to merge this after fixing up the pname thing. |
@GrahamcOfBorg build dydisnix |
Co-Authored-By: Ryan Mulligan <[email protected]>
@GrahamcOfBorg build dydisnix |
Thank you for your contributions. This has been automatically marked as stale because it has had no activity for 180 days. If this is still important to you, we ask that you leave a comment below. Your comment can be as simple as "still important to me". This lets people see that at least one person still cares about this. Someone will have to do this at most twice a year if there is no other activity. Here are suggestions that might help resolve this more quickly:
|
still important to me |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please fix build failures.
3dd3b55
to
868c609
Compare
@tomberek your recent commits have an e-mail address that isn't recognized by GitHub. You might want to change those ( |
868c609
to
bbbf2ee
Compare
Result of 2 packages built:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Builds for me, all the binaries at least run and display their help.
@@ -18,7 +18,7 @@ stdenv.mkDerivation { | |||
meta = { |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
tiny nit: this and the dydisnix meta attrsets would be cleaner with with stdenv.lib;
like you've done in libnixxml, but it shouldn't block merging this.
## Changelog for nixpkgs: Commits: [NixOS/nixpkgs@58f29d3c...684e7315](NixOS/nixpkgs@58f29d3...684e731) * [`0fb14ea4`](NixOS/nixpkgs@0fb14ea) terraform-providers.google-beta: 3.18.0 -> 3.47.0 * [`4db23927`](NixOS/nixpkgs@4db2392) mullvad-vpn: add iproute2 * [`688c8c03`](NixOS/nixpkgs@688c8c0) terraform-providers.postgresql: 1.6.0 -> 1.7.1 * [`ce84cc06`](NixOS/nixpkgs@ce84cc0) texlive: Use lib.unique for uniqueness checks * [`22965d84`](NixOS/nixpkgs@22965d8) sssd: fix build on glibc-2.32 * [`c384c540`](NixOS/nixpkgs@c384c54) linux: 4.14.208 -> 4.14.209 * [`06ba11d0`](NixOS/nixpkgs@06ba11d) linux: 4.19.159 -> 4.19.160 * [`d17c554f`](NixOS/nixpkgs@d17c554) linux: 4.4.245 -> 4.4.246 * [`a17655a2`](NixOS/nixpkgs@a17655a) linux: 4.9.245 -> 4.9.246 * [`53738d41`](NixOS/nixpkgs@53738d4) linux: 5.4.79 -> 5.4.80 * [`513afc73`](NixOS/nixpkgs@513afc7) linux: 5.9.10 -> 5.9.11 * [`874e2500`](NixOS/nixpkgs@874e250) linux-rt_5_4: 5.4.77-rt43 -> 5.4.78-rt44 * [`4de5d2b0`](NixOS/nixpkgs@4de5d2b) influxdb2: init at v2.0.2 (NixOS/nixpkgs#104717) * [`366791e9`](NixOS/nixpkgs@366791e) golangci-lint: 1.32.2 -> 1.33.0 (NixOS/nixpkgs#104768) * [`54130aa9`](NixOS/nixpkgs@54130aa) dhallPackages.Prelude: 13.0.0 -> 19.0.0 * [`2545e3f3`](NixOS/nixpkgs@2545e3f) python2Packages.cryptography: mark insecure, CVE-2020-25659 * [`6993bd0b`](NixOS/nixpkgs@6993bd0) rustscan: 1.10.1 -> 2.0.1 * [`0a1c0fe6`](NixOS/nixpkgs@0a1c0fe) k9s: 0.23.10 -> 0.24.1 * [`bc49a081`](NixOS/nixpkgs@bc49a08) utillinux: rename to util-linux * [`a0f09270`](NixOS/nixpkgs@a0f0927) vscode: fix opening files with pcmanfm * [`297d1d6b`](NixOS/nixpkgs@297d1d6) inkscape: add inkcut extension * [`db432583`](NixOS/nixpkgs@db43258) signal-desktop: 1.38.1 -> 1.38.2 * [`4e721164`](NixOS/nixpkgs@4e72116) wlsunset: init at 0.1.0 (NixOS/nixpkgs#103606) * [`32df7801`](NixOS/nixpkgs@32df780) svtplay-dl: 2.7 -> 2.8 * [`18fab623`](NixOS/nixpkgs@18fab62) svtplay-dl: Enable on macOS as well * [`9a515a9d`](NixOS/nixpkgs@9a515a9) svtplay-dl: add ffmpeg as dependency * [`2044fa17`](NixOS/nixpkgs@2044fa1) sssd: fix nss collision with upstream patch * [`b214b290`](NixOS/nixpkgs@b214b29) eksctl: 0.31.0 -> 0.32.0 * [`b660fbbb`](NixOS/nixpkgs@b660fbb) exodus: 20.11.10 -> 20.11.21 * [`fa0fd015`](NixOS/nixpkgs@fa0fd01) bat: 0.17.0 -> 0.17.1 * [`285f69eb`](NixOS/nixpkgs@285f69e) pythonPackages.gradient_statsd: Disable tests * [`6794b7ee`](NixOS/nixpkgs@6794b7e) nix-update: 0.1 -> 0.2 * [`3873438b`](NixOS/nixpkgs@3873438) python3Packages.mss: 6.0.0 -> 6.1.0 * [`8d4af2e0`](NixOS/nixpkgs@8d4af2e) gitAndTools.gh: 1.2.1 -> 1.3.0 * [`ae61f8ac`](NixOS/nixpkgs@ae61f8a) gnome3.eog: 3.38.0 -> 3.38.1 * [`d9343445`](NixOS/nixpkgs@d934344) nixos/factorio: add openFirewall option * [`3d3bcc5c`](NixOS/nixpkgs@3d3bcc5) nixos/factorio: Don't open firewall ports by default * [`edd823b7`](NixOS/nixpkgs@edd823b) devede: move to GitLab, 4.8.8 -> 4.16.0 * [`19036e0c`](NixOS/nixpkgs@19036e0) opensc: 0.20.0 -> 0.21.0 * [`a52c4f0f`](NixOS/nixpkgs@a52c4f0) gnome3.devhelp: 3.38.0 -> 3.38.1 * [`50f6a123`](NixOS/nixpkgs@50f6a12) nodejs-12_x: 12.19.1 -> 12.20.0 * [`46f22701`](NixOS/nixpkgs@46f2270) nodejs-15_x: 15.2.1 -> 15.3.0 * [`b92942f4`](NixOS/nixpkgs@b92942f) systemd: use withPortabled in mesonFlags * [`3af181d8`](NixOS/nixpkgs@3af181d) dislocker: 0.7.1 -> 0.7.3 * [`129c30e2`](NixOS/nixpkgs@129c30e) resilio-sync: add aarch64 support * [`7275a26e`](NixOS/nixpkgs@7275a26) gcompris: 0.98 -> 1.0 * [`5451c908`](NixOS/nixpkgs@5451c90) glow: 1.2.0 -> 1.2.1 * [`77c7db03`](NixOS/nixpkgs@77c7db0) python3Packages.pyHS100: 0.3.5.1 -> 0.3.5.2 * [`7f5dfd2b`](NixOS/nixpkgs@7f5dfd2) evolution-data-server: 3.38.1 -> 3.38.2 * [`668e7a44`](NixOS/nixpkgs@668e7a4) gnome3.gnome-getting-started-docs: 3.36.2 -> 3.38.0 * [`f2b2eb23`](NixOS/nixpkgs@f2b2eb2) vips: add librsvg dependency * [`58b9e10a`](NixOS/nixpkgs@58b9e10) flyway: 7.2.0 -> 7.2.1 * [`80b1ecca`](NixOS/nixpkgs@80b1ecc) cagebreak: 1.4.3 -> 1.4.4 * [`79a91016`](NixOS/nixpkgs@79a9101) tmuxp: 1.6.2 -> 1.6.3 * [`72752ab8`](NixOS/nixpkgs@72752ab) vimwiki-markdown: 0.3.2 -> 0.3.3 * [`9c03664e`](NixOS/nixpkgs@9c03664) plex-media-player: remove myself as a maintainer * [`6849c4a4`](NixOS/nixpkgs@6849c4a) urh: 2.8.9 -> 2.9.0 * [`3174ae17`](NixOS/nixpkgs@3174ae1) mavproxy: 1.8.24 -> 1.8.27 * [`d624e520`](NixOS/nixpkgs@d624e52) vcstool: 0.2.14 -> 0.2.15 * [`5603d2eb`](NixOS/nixpkgs@5603d2e) jira-cli: 2.2 -> 3.0 * [`e40f4acb`](NixOS/nixpkgs@e40f4ac) ocaml: minor refactoring * [`254f2bad`](NixOS/nixpkgs@254f2ba) ocaml-ng.ocamlPackages_4_12.ocaml: init at 4.12.0-α1 * [`6cea12cc`](NixOS/nixpkgs@6cea12c) alacritty: 0.6.0-rc1 -> 0.6.0 * [`af10cef5`](NixOS/nixpkgs@af10cef) python37Packages.thinc: 7.4.2 -> 7.4.3 * [`5790bb07`](NixOS/nixpkgs@5790bb0) nixos auto-upgrade: remove flag when flake * [`35e50449`](NixOS/nixpkgs@35e5044) python37Packages.trimesh: 3.8.13 -> 3.8.14 * [`c5389c57`](NixOS/nixpkgs@c5389c5) gnome-user-docs: 3.38.1 -> 3.38.2 * [`3725f9ed`](NixOS/nixpkgs@3725f9e) iosevka: update location of parameters.toml * [`e8ee6a40`](NixOS/nixpkgs@e8ee6a4) gnome3.gnome-music: 3.38.1 -> 3.38.2 * [`03df9f54`](NixOS/nixpkgs@03df9f5) terragrunt: 0.26.4 -> 0.26.5 * [`3ed220fd`](NixOS/nixpkgs@3ed220f) gnome3.gedit: 3.38.0 -> 3.38.1 * [`3716bb5e`](NixOS/nixpkgs@3716bb5) gnome3.gnome-calculator: 3.38.1 -> 3.38.2 * [`cd54ef20`](NixOS/nixpkgs@cd54ef2) glade: 3.38.1 -> 3.38.2 * [`2ea6e83a`](NixOS/nixpkgs@2ea6e83) gnome3.gnome-devel-docs: 3.38.1 -> 3.38.2 * [`d75276a2`](NixOS/nixpkgs@d75276a) meli: fix runtime error with libnotmuch5 * [`118695a3`](NixOS/nixpkgs@118695a) pass: seperate dmenu from x11Support * [`0dbd4c98`](NixOS/nixpkgs@0dbd4c9) viber: 7.0.0.1035 -> 13.3.1.22 * [`f6dfcaa3`](NixOS/nixpkgs@f6dfcaa) mdds: mark broken on darwin * [`ff2aface`](NixOS/nixpkgs@ff2afac) rgp: 1.8 -> 1.9 * [`88bc9aba`](NixOS/nixpkgs@88bc9ab) firefox-beta-bin: 81.0b4 -> 84.0b4 * [`41c91ed0`](NixOS/nixpkgs@41c91ed) firefox-devedition-bin: 80.0b8 -> 84.0b4 * [`7677449d`](NixOS/nixpkgs@7677449) mpc-qt: Fix compilation failure due to mpv changes * [`96ce7ccb`](NixOS/nixpkgs@96ce7cc) slirp4netns: 1.1.6 -> 1.1.7 * [`9100dac4`](NixOS/nixpkgs@9100dac) chromedriver: 85.0.4183.87 -> 86.0.4240.22 (NixOS/nixpkgs#101974) * [`bee90bae`](NixOS/nixpkgs@bee90ba) perlPackages.TermReadPassword: init at 0.11 * [`ad62155c`](NixOS/nixpkgs@ad62155) nixos/zram: add zramSwap.memoryMax option * [`6421a1b0`](NixOS/nixpkgs@6421a1b) factorio-experimental, factorio-headless-experimental: 1.1.0 -> 1.1.1 * [`8406e0bc`](NixOS/nixpkgs@8406e0b) yubioath-desktop: fix python git dependency (NixOS/nixpkgs#104884) * [`3ae802b3`](NixOS/nixpkgs@3ae802b) pwntools: 4.2.2 -> 4.3.0 * [`13b8ff4e`](NixOS/nixpkgs@13b8ff4) fuse-overlayfs: 1.2.0 -> 1.3.0 * [`ac0ac4fe`](NixOS/nixpkgs@ac0ac4f) dydisnix: init at unstable (NixOS/nixpkgs#49366) * [`17b13546`](NixOS/nixpkgs@17b1354) mosh: name -> pname * [`e981d3a4`](NixOS/nixpkgs@e981d3a) photoflow: 2018-08-28 -> 2020-08-28 * [`d402d913`](NixOS/nixpkgs@d402d91) bluespec: unstable-2020.02.09 -> unstable-2020.11.04 * [`7afd5050`](NixOS/nixpkgs@7afd505) python37Packages.jupyterlab-git: 0.22.3 -> 0.23.1 * [`3c72ba68`](NixOS/nixpkgs@3c72ba6) python3Packages.jupyterlab-git: Disable tests on darwin * [`8fb4c68d`](NixOS/nixpkgs@8fb4c68) python37Packages.genanki: 0.9.0 -> 0.9.1 * [`a120e540`](NixOS/nixpkgs@a120e54) python37Packages.smart_open: 3.0.0 -> 4.0.0 * [`a2242b21`](NixOS/nixpkgs@a2242b2) python37Packages.ha-ffmpeg: 2.0 -> 3.0.2 * [`fd1ed8e9`](NixOS/nixpkgs@fd1ed8e) python37Packages.dogpile_cache: 1.1.0 -> 1.1.1 * [`b48d7144`](NixOS/nixpkgs@b48d714) mpc-qt: use fetchpatch instead of fetchurl * [`b41f944e`](NixOS/nixpkgs@b41f944) python37Packages.spacy: 2.3.2 -> 2.3.3 * [`1f1ac382`](NixOS/nixpkgs@1f1ac38) python37Packages.cftime: 1.2.1 -> 1.3.0 * [`e6e0d988`](NixOS/nixpkgs@e6e0d98) executor: 23.1 -> 23.2 * [`c024d24d`](NixOS/nixpkgs@c024d24) consul: 1.8.5 -> 1.8.6 * [`d26dae67`](NixOS/nixpkgs@d26dae6) omnisharp-roslyn: 1.37.3 -> 1.37.4 * [`f9b2e8f5`](NixOS/nixpkgs@f9b2e8f) google-cloud-sdk: 315.0.0 -> 319.0.0 (NixOS/nixpkgs#104886) * [`1ff8d1b1`](NixOS/nixpkgs@1ff8d1b) python3Packages.botocore: 1.18.18 -> 1.19.25 * [`fce75e16`](NixOS/nixpkgs@fce75e1) python3Packages.boto3: 1.15.18 -> 1.16.25 * [`360a14dc`](NixOS/nixpkgs@360a14d) awscli: 1.18.150 -> 1.18.185 * [`4196aa96`](NixOS/nixpkgs@4196aa9) awscli: Add test * [`e204319c`](NixOS/nixpkgs@e204319) pythonPackages.pyscard: Remove patch that is included in 1.9.9 and 2.0.0 * [`66171223`](NixOS/nixpkgs@6617122) gitAndTools.pass-git-helper: 0.4 -> 1.1.0 * [`4e4d498f`](NixOS/nixpkgs@4e4d498) grafana: 7.3.3 -> 7.3.4 * [`9c2351cf`](NixOS/nixpkgs@9c2351c) mpv: enable sixel support * [`2e4d7143`](NixOS/nixpkgs@2e4d714) nixos/tests/networking: Alleviate race in scripted test * [`fb05770a`](NixOS/nixpkgs@fb05770) httpstat: 1.2.1 -> 1.3.0 * [`c46bb0cc`](NixOS/nixpkgs@c46bb0c) scala: Fix test references * [`2b714a3d`](NixOS/nixpkgs@2b714a3) python37Packages.timeout-decorator: 0.4.1 -> 0.5.0 * [`d4e0e44f`](NixOS/nixpkgs@d4e0e44) pythonPackages.pyscard: Remove unused input * [`2e3c491a`](NixOS/nixpkgs@2e3c491) oh-my-zsh: 2020-11-22 → 2020-11-25 * [`ed0d6be5`](NixOS/nixpkgs@ed0d6be) xterm: Add test reference
Motivation for this change
Include dydisnix into nixpkgs
@svanderburg: inclusion into nixpkgs may provide easier entry for additional users, thoughts?
Things done
Added
./bootstrap
to the standard configure/make/make install.sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)