-
-
Notifications
You must be signed in to change notification settings - Fork 14.6k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rapidcheck: init at unstable-2018-09-27 #48048
Conversation
Success on aarch64-linux (full log) Attempted: rapidcheck Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: rapidcheck Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: rapidcheck Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: rapidcheck Partial log (click to expand)
|
Success on x86_64-darwin (full log) Attempted: rapidcheck Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: rapidcheck Partial log (click to expand)
|
sha256 = "0n8l0mlq9xqmpkgcj5xicicd1my2cfwxg25zdy8347dqkl1ppgbs"; | ||
}; | ||
|
||
buildInputs = [ cmake ]; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cmake
should be in nativeBuildInputs
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I wonder if tips like this could be automated �
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
opened a borg issue here NixOS/ofborg#245
|
||
stdenv.mkDerivation rec{ | ||
name = "rapidcheck-${version}"; | ||
version = "git-20180927"; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
On package naming the manual would rather suggest rapidcheck-unstable-2018-09-27
rapidcheck is a C++ property-based testing framework inspired by QuickCheck Signed-off-by: William Casarin <[email protected]>
Success on x86_64-linux (full log) Attempted: rapidcheck Partial log (click to expand)
|
Success on aarch64-linux (full log) Attempted: rapidcheck Partial log (click to expand)
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
Success on x86_64-darwin (full log) Attempted: rapidcheck Partial log (click to expand)
|
rapidcheck is a C++ property-based testing framework inspired by QuickCheck
Signed-off-by: William Casarin [email protected]
Motivation for this change
Needed it for testing property based tests recently added to Bitcoin
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)