Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

eiskaltdcpp: mark linux only #47148

Merged
merged 1 commit into from
Sep 24, 2018
Merged

eiskaltdcpp: mark linux only #47148

merged 1 commit into from
Sep 24, 2018

Conversation

LnL7
Copy link
Member

@LnL7 LnL7 commented Sep 21, 2018

The darwin build fails and other platforms will probably run into
similar issues.

Determining if the Q_WS_QWS exist failed with the following output:
Change Dir: /tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp

Run Build Command:"/nix/store/qfag24z6xsr6jkyi8gb4cv62rp945rbk-gnumake-4.2.1/bin/make" "cmTC_14e67/fast"
/nix/store/qfag24z6xsr6jkyi8gb4cv62rp945rbk-gnumake-4.2.1/bin/make -f CMakeFiles/cmTC_14e67.dir/build.make CMakeFiles/cmTC_14e67.dir/build
make[1]: Entering directory '/private/tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp'
Building CXX object CMakeFiles/cmTC_14e67.dir/CheckSymbolExists.cxx.o
/nix/store/2gdwhdzhy4iwkp7fh8v6gy6nxj1zi9pv-clang-wrapper-5.0.2/bin/clang++   -I/nix/store/8dzqilmdr0p3qmmrxh51xk7wli6grm0i-qt-4.8.7/include -F/nix/store/8dzqilmdr0p3qmmrxh51xk7wli6grm0i-qt-4.8.7/lib  -std=c++0x -pipe -Wformat -Werror=format-security  -arch x86_64   -o CMakeFiles/cmTC_14e67.dir/CheckSymbolExists.cxx.o -c /tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
/tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx:8:19: error: use of undeclared identifier 'Q_WS_QWS'
  return ((int*)(&Q_WS_QWS))[argc];
              ^

/cc ZHF #45961

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Fits CONTRIBUTING.md.

The darwin build fails and other platforms will probably run into
similar issues.

    Determining if the Q_WS_QWS exist failed with the following output:
    Change Dir: /tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp

    Run Build Command:"/nix/store/qfag24z6xsr6jkyi8gb4cv62rp945rbk-gnumake-4.2.1/bin/make" "cmTC_14e67/fast"
    /nix/store/qfag24z6xsr6jkyi8gb4cv62rp945rbk-gnumake-4.2.1/bin/make -f CMakeFiles/cmTC_14e67.dir/build.make CMakeFiles/cmTC_14e67.dir/build
    make[1]: Entering directory '/private/tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp'
    Building CXX object CMakeFiles/cmTC_14e67.dir/CheckSymbolExists.cxx.o
    /nix/store/2gdwhdzhy4iwkp7fh8v6gy6nxj1zi9pv-clang-wrapper-5.0.2/bin/clang++   -I/nix/store/8dzqilmdr0p3qmmrxh51xk7wli6grm0i-qt-4.8.7/include -F/nix/store/8dzqilmdr0p3qmmrxh51xk7wli6grm0i-qt-4.8.7/lib  -std=c++0x -pipe -Wformat -Werror=format-security  -arch x86_64   -o CMakeFiles/cmTC_14e67.dir/CheckSymbolExists.cxx.o -c /tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx
    /tmp/nix-build-eiskaltdcpp-2.2.10.drv-0/source/build/CMakeFiles/CMakeTmp/CheckSymbolExists.cxx:8:19: error: use of undeclared identifier 'Q_WS_QWS'
      return ((int*)(&Q_WS_QWS))[argc];
                  ^

/cc ZHF NixOS#45961
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

@GrahamcOfBorg build eiskaltdcpp

@GrahamcOfBorg
Copy link

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: eiskaltdcpp

Partial log (click to expand)


a) For `nixos-rebuild` you can set
  { nixpkgs.config.allowUnsupportedSystem = true; }
in configuration.nix to override this.

b) For `nix-env`, `nix-build`, `nix-shell` or any other Nix command you can add
  { allowUnsupportedSystem = true; }
to ~/.config/nixpkgs/config.nix.


@GrahamcOfBorg
Copy link

Success on x86_64-linux (full log)

Attempted: eiskaltdcpp

Partial log (click to expand)

/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/update_geoip: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/amr.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/mod.amarok.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/deadbeef.ru_RU.UTF-8.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/mpc.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/rhythmbox.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/qmmp.ru_RU.UTF-8.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/mpris_now_playing.en_US.sh: interpreter directive changed from "/bin/bash" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/bash"
/nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/audacious.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/czx8vkrb9jdgjyz8qfksh10vrnqa723l-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/0rpq2ijdilghp0z8wbva66vm2lka0jpy-eiskaltdcpp-2.2.10...

@GrahamcOfBorg
Copy link

Success on aarch64-linux (full log)

Attempted: eiskaltdcpp

Partial log (click to expand)

/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/update_geoip: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/amr.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/audacious.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/deadbeef.ru_RU.UTF-8.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/mod.amarok.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/mpc.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/mpris_now_playing.en_US.sh: interpreter directive changed from "/bin/bash" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/bash"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/qmmp.ru_RU.UTF-8.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
/nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10/share/eiskaltdcpp/examples/rhythmbox.en_US.sh: interpreter directive changed from "/bin/sh" to "/nix/store/fqm2x6kiay1q4vg7pqp4wp17bdijlyc3-bash-4.4-p23/bin/sh"
checking for references to /build in /nix/store/nz1661jfm8r8454dwm2c8nkdmm1s2k9a-eiskaltdcpp-2.2.10...

@Mic92 Mic92 merged commit 841613d into NixOS:master Sep 24, 2018
@Mic92
Copy link
Member

Mic92 commented Sep 24, 2018

backport: 3cee0ce

@LnL7 LnL7 deleted the darwin-broken-e branch September 24, 2018 18:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants