youtube-dl: 2018.08.28 -> 2018.09.01, fix youtube download

[timokau]

Motivation for this change

Youtube made an update that breaks youtube-dl on many videos. Since that is a big breakage for many users (for example those using mpv to stream youtube), we should include the fix (unmerged upstream PR ytdl-org/youtube-dl#17464) as soon as possible.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Determined the impact on package closure size (by running nix path-info -S before and after)
• Fits CONTRIBUTING.md.

---

[GrahamcOfBorg]

Success on aarch64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.9.1
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01
gzipping man pages under /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/share/man/
strip is /nix/store/y4ymnvgxygpq05h03kyzbj572zmh6zla-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/lib  /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/bin
patching script interpreter paths in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01
checking for references to /build in /nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01...
wrapping `/nix/store/syw4vj26b285giv1cjbj4ky371sp1pl6-python3.6-youtube-dl-2018.09.01/bin/youtube-dl'...

[GrahamcOfBorg]

Success on x86_64-darwin (full log)

Attempted: youtube-dl

Partial log (click to expand)

  The script youtube-dl is installed in '/nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/bin' which is not on PATH.
  Consider adding this directory to PATH or, if you prefer to suppress this warning, use --no-warn-script-location.
Successfully installed youtube-dl-2018.9.1
/private/tmp/nix-build-python3.6-youtube-dl-2018.09.01.drv-0/youtube-dl
post-installation fixup
gzipping man pages under /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/share/man/
strip is /nix/store/df6k4mgdjxciy0f637lryp7c9ln7n1m3-cctools-binutils-darwin/bin/strip
stripping (with command strip and flags -S) in /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/lib  /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/bin
patching script interpreter paths in /nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01
wrapping `/nix/store/p06hsz0cmli7091l3xcbvcix525qrbbb-python3.6-youtube-dl-2018.09.01/bin/youtube-dl'...

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: youtube-dl

Partial log (click to expand)

Successfully installed youtube-dl-2018.9.1
/build/youtube-dl
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01
gzipping man pages under /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/share/man/
strip is /nix/store/h0lbngpv6ln56hjj59i6l77vxq25flbz-binutils-2.30/bin/strip
stripping (with command strip and flags -S) in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/lib  /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/bin
patching script interpreter paths in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01
checking for references to /build in /nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01...
wrapping `/nix/store/ms59m4ii98r2blfc5j6qadqbwph5vwfj-python3.6-youtube-dl-2018.09.01/bin/youtube-dl'...