-
-
Notifications
You must be signed in to change notification settings - Fork 14.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[18.09] Revert "arrow-cpp: 0.9.0 -> 0.10.0" #45991
[18.09] Revert "arrow-cpp: 0.9.0 -> 0.10.0" #45991
Conversation
ZHF #45960 |
Check if there is any remaining issues: |
Failure on x86_64-darwin (full log) Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp Partial log (click to expand)
|
Timed out, unknown build status on aarch64-linux (full log) Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp Partial log (click to expand)
|
let's start the build again, x86_64-linux got lost somehow |
Failure on x86_64-darwin (full log) Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp Partial log (click to expand)
|
pyarrow actually never built on darwin according to hydra logs, https://hydra.nixos.org/job/nixpkgs/trunk/python27Packages.pyarrow.x86_64-darwin/all , so let's ignore that for now. |
@xeji Yes, I'm aware. It builds on my machine somehow. I haven't had a chance to investigate the issue (given I can't reproduce). |
Success on x86_64-linux (full log) Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp Partial log (click to expand)
|
Failure on aarch64-linux (full log) Attempted: arrow-cpp, python2Packages.pyarrow, python3Packages.pyarrow, parquet-cpp Partial log (click to expand)
|
aarch64 failure looks unrelated. @veprbl is this ok to merge now? |
@xeji Yes, absolutely. |
Hold off the upgrade until parquet 1.5.0 is released.
This reverts commit 72d6307.
(cherry picked from commit 992d64b)
Motivation for this change
Fixes parquet-cpp for 18.09. PR against
master
is #45990Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)