Adding HLearn #4566
Closed
Adding HLearn #4566
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
cc @peti |
edwtjo
force-pushed
the
hlearn
branch
2 times, most recently
from
fa631e5 to
316323a
Compare
|
Is there no way to build these packages with a recent |
| @@ -687,6 +691,7 @@ self : let callPackage = x : y : modifyPrio (newScope self x y); in | |||
|
|
|||
| djinnLib = callPackage ../development/libraries/haskell/djinn-lib {}; | |||
|
|
|||
| dlist_5_0 = callPackage ../development/libraries/haskell/dlist/5.0.nix {}; | |||
There was a problem hiding this comment.
Please rename the default.nix file to use a version-number.nix scheme, too. Also, both attributes should have the package version included plus a third attribute that forwards to the default choice.
|
Reported dlist issue upstream at mikeizbicki/ConstraintKinds#7 |
|
Didn't need dlist-5.0 but needed two versions of ConstraintKinds, calling this WIP. Doesn't compile. Thanks for the pointers @peti. |
|
I'm trying to clean up our list of open issues to make things more manageable for the upcoming 14.11 release. Can you please open a new PR when this effort is ready to be merging? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.