-
-
Notifications
You must be signed in to change notification settings - Fork 14.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
python.pkgs.tensorflow-tensorboard: 1.7.0 -> 1.9.0 #42783
Conversation
python.pkgs.html5lib_0_9999999 can now be removed as well
1980801
to
9a0ec5f
Compare
It seems like this breaks the build of tensorflow (Python 3 seems fine however): |
Failure on aarch64-linux (full log) Attempted: python2.pkgs.tensorflow Partial log (click to expand)
|
Failure on x86_64-linux (full log) Attempted: python2.pkgs.tensorflow Partial log (click to expand)
|
@GrahamcOfBorg build python3.pkgs.tensorflow |
Failure on aarch64-linux (full log) Attempted: python3.pkgs.tensorflow Partial log (click to expand)
|
Success on x86_64-linux (full log) Attempted: python3.pkgs.tensorflow Partial log (click to expand)
|
@dotlambda Note that the tensorflow build for most recent python does not check dependencies, precisely because of the bleach issue. So this may explain why "python3 is fine". Presumably though, you will need to upgrade the version of tensorflow at the same time as tensorboard to keep it happy. I see that the current version is 1.9.0-rc2 --- why not wait until 1.9.0 is out and try then with consistent versions? |
@jyp Tensorflow 1.9.0 has been released in the meantime. Would you mind updating it and including my commits? |
@dotlambda I tried to update to tensorflow 1.9.0, but unfortunately it does not work. It has a dependency on setuptools <=39.1.0. But, apparently, setuptools has a special status and we can't install an older version along the current one. I am out of ideas. |
included in #44599 |
Motivation for this change
Tensorboard now ships a vendored version of bleach, so we can get rid of
python.pkgs.bleach_1_5_0
: tensorflow/tensorboard#1142Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)