Make plymouth work with gdm wayland #39978
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
@jtojnar is getting gdm to use wayland in #39615. Trying it out I ran into a problem where gdm would fail the first time when using plymouth (on a 3rd gen X1 carbon, but not in a VM for some reason).
According to the service directory in plymouth "multi-user.target" should want "plymouth-quit-wait.service":
This change fixed gdm running wayland, and seems like reasonable change since it's apparently expected by plymouth.
However the change made other display managers not quit plymouth properly, leaving it running in the background consuming cpu. Removing "multi-user.target" from
plymouth-quit.after
makes plymouth quit as expected. Not sure why having it there was a problem though.cc @abbradar (sorry for bugging you) as he's the author of the code I'm changing.
Things done
Tested all the display managers in a VM. All are showing the console on stage 1. as expected (I'm assuming this is needed for LUKS password). Also tested without
xserver
which also worked fine.Though I haven't tested the configuration with LUKS enabled. If someone knows how to test this easily in eg. a VM that would be great.
build-use-sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)