darwin.opencflite: fix build

[knedlsepp]

Motivation for this change

ZHF-18.03: #36453
See: https://hydra.nixos.org/job/nixos/release-18.03/nixpkgs.darwin.opencflite.x86_64-linux
Please backport to 18.03.

Things done

• Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
• Built on platform(s)
  • NixOS
  • macOS
  • other Linux distributions
• Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
• Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
• Tested execution of all binary files (usually in ./result/bin/)
• Fits CONTRIBUTING.md.

---

[LnL7]

@GrahamcOfBorg build darwin.opencflite

[GrahamcOfBorg]

No attempt on x86_64-darwin (full log)

The following builds were skipped because they don't evaluate on x86_64-darwin: darwin.opencflite

Partial log (click to expand)

Cannot nix-instantiate `darwin.opencflite' because:
�[31;1merror:�[0m while evaluating the attribute 'configureFlags' of the derivation 'opencflite-476.19.0' at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/stdenv/generic/make-derivation.nix�[0m:148:11:
value is null while a set was expected, at �[1m/private/var/lib/ofborg/builds/repo/38dca4e3aa6bca43ea96d2fcc04e8229/builder/grahamc-ndnd/pkgs/os-specific/darwin/opencflite/default.nix�[0m:12:37

[GrahamcOfBorg]

Success on x86_64-linux (full log)

Attempted: darwin.opencflite

Partial log (click to expand)

make[1]: Leaving directory '/build/opencflite-476.19.0/examples'
post-installation fixup
shrinking RPATHs of ELF executables and libraries in /nix/store/rqd0vwspgik9aiqak2bn1k566wwfzgmd-opencflite-476.19.0
shrinking /nix/store/rqd0vwspgik9aiqak2bn1k566wwfzgmd-opencflite-476.19.0/lib/libCoreFoundation.so.476.0.19
shrinking /nix/store/rqd0vwspgik9aiqak2bn1k566wwfzgmd-opencflite-476.19.0/lib/libCoreFoundation_debug.so.476.0.19
shrinking /nix/store/rqd0vwspgik9aiqak2bn1k566wwfzgmd-opencflite-476.19.0/lib/libCoreFoundation_profile.so.476.0.19
strip is /nix/store/fzcs0fn6bb04m82frhlb78nc03ny3w55-binutils-2.28.1/bin/strip
stripping (with command strip and flags -S) in /nix/store/rqd0vwspgik9aiqak2bn1k566wwfzgmd-opencflite-476.19.0/lib
patching script interpreter paths in /nix/store/rqd0vwspgik9aiqak2bn1k566wwfzgmd-opencflite-476.19.0
checking for references to /build in /nix/store/rqd0vwspgik9aiqak2bn1k566wwfzgmd-opencflite-476.19.0...

[GrahamcOfBorg]

Failure on aarch64-linux (full log)

Attempted: darwin.opencflite

Partial log (click to expand)

 ^
CFRunLoop.c: In function '__CFRunLoopIsSleeping':
CFRunLoop.c:441:1: warning: control reaches end of non-void function [-Wreturn-type]
 }
 ^
make[1]: *** [Makefile:1821: libCoreFoundation_debug_la-CFRunLoop.lo] Error 1
make[1]: Leaving directory '/build/opencflite-476.19.0'
make: *** [Makefile:2541: all-recursive] Error 1
builder for '/nix/store/6847lf5ilyr6bnnnbjc3am9xndvhjy32-opencflite-476.19.0.drv' failed with exit code 2
�[31;1merror:�[0m build of '/nix/store/6847lf5ilyr6bnnnbjc3am9xndvhjy32-opencflite-476.19.0.drv' failed

[matthewbauer]

Not sure what the aarch64 error is. We might need to mark it as broken for aarch64.

[knedlsepp]

include/CoreFoundation/CFBase.h:58:2: error: #error Both __BIG_ENDIAN__ and __LITTLE_ENDIAN__ cannot be false

Maybe defining the endiannes via nix_cflags suffices?

[matthewbauer]

Ok- we can fix that in another PR.

[LnL7]

I didn't merge this yet because of the build failure, was that fixed?

[matthewbauer]

Well this fixes it on x86_64-linux. It was broken on all linux so it’s at least an improvement.

[LnL7]

Oh, I didn't realise this was for the linux build 😄