pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build #38245

xeji · 2018-03-31T17:55:40Z

Motivation for this change

ZHF #36453 . Build (tests) failed.

minor bump, fix tests, move to development/python-modules

Things done

Tested using sandboxing (nix.useSandbox on NixOS, or option build-use-sandbox in nix.conf on non-NixOS)
Built on platform(s)
- NixOS
- macOS
- other Linux distributions
Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
Tested execution of all binary files (usually in ./result/bin/)
Fits CONTRIBUTING.md.

xeji · 2018-03-31T20:37:58Z

@GrahamcOfBorg build python27Packages.imbalanced-learn python36Packages.imbalanced-learn

GrahamcOfBorg · 2018-03-31T20:40:01Z

Success on x86_64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)


=============================== warnings summary ===============================
doc/under_sampling.rst::under_sampling.rst
  /nix/store/kahw886ikcv543r4h4xrdg6lz2mcbpx3-python2.7-imbalanced-learn-0.3.3/lib/python2.7/site-packages/imblearn/under_sampling/prototype_selection/one_sided_selection.py:197: DeprecationWarning: in the future out of bounds indices will raise an error instead of being ignored by `numpy.delete`.
    idx_maj_extracted = np.delete(idx_maj, idx_maj_sample, axis=0)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
===================== 5 passed, 1 warnings in 5.47 seconds =====================
/nix/store/kahw886ikcv543r4h4xrdg6lz2mcbpx3-python2.7-imbalanced-learn-0.3.3
/nix/store/4lr79rcx4vnpv1fkwglm8d1sdzcy69f1-python3.6-imbalanced-learn-0.3.3

GrahamcOfBorg · 2018-03-31T21:38:33Z

Failure on aarch64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)

........................................................................ [ 67%]
................................................................         [ 68%]
../../nix/store/v67mrh16nc6169icwhivb2b98l742lqc-python2.7-pandas-0.22.0/lib/python2.7/site-packages/pandas/tests/io/formats/test_printing.py . [ 68%]
......sssss                                                              [ 68%]
../../nix/store/v67mrh16nc6169icwhivb2b98l742lqc-python2.7-pandas-0.22.0/lib/python2.7/site-packages/pandas/tests/io/formats/test_style.py . [ 68%]
building of '/nix/store/qaan05bxk57cz3gcqn1ykld9v4884p22-python2.7-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/gm853kvwibpnc5l24pgfypdkcqvzxsxv-python2.7-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
building of '/nix/store/qs99hvyac7xkv7fzazgqwlhxkvkc0rc1-python3.6-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/mxgbrhmla632fjrzn525b9m7qi0wdpqh-python3.6-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/gm853kvwibpnc5l24pgfypdkcqvzxsxv-python2.7-imbalanced-learn-0.3.3.drv', '/nix/store/mxgbrhmla632fjrzn525b9m7qi0wdpqh-python3.6-imbalanced-learn-0.3.3.drv' failed

dotlambda · 2018-03-31T22:00:29Z

pkgs/development/python-modules/imbalanced-learn/default.nix

+{ stdenv, buildPythonPackage, fetchPypi, scikitlearn, pandas, nose, pytest }:
+
+buildPythonPackage rec {
+


unnecessary whitespace

dotlambda · 2018-03-31T22:01:53Z

pkgs/development/python-modules/imbalanced-learn/default.nix

+    '';
+
+    propagatedBuildInputs = [ scikitlearn ];
+    buildInputs = [ pandas ];


Do you know if this is an optional dependency? Why is it in buildInputs?

Looking at the source code, it is optional and only used in a test utility. Without it, a number of tests are skipped. Moved to checkInputs.

dotlambda · 2018-03-31T22:02:30Z

pkgs/development/python-modules/imbalanced-learn/default.nix

+    };
+
+    preConfigure = ''
+      export HOME=$PWD


Is this needed for anything other than the tests? If not, it belongs into checkPhase.

Tests only. moved to checkPhase.

minor bump, fix tests, move to development/python-modules

xeji · 2018-04-01T00:08:30Z

@GrahamcOfBorg build python27Packages.imbalanced-learn python36Packages.imbalanced-learn

GrahamcOfBorg · 2018-04-01T00:13:45Z

Success on x86_64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)


doc/under_sampling.rst::under_sampling.rst

  /nix/store/ifvjl87nlarvhrmn5s2qdh3jq0s9z7x5-python3.6-imbalanced-learn-0.3.3/lib/python3.6/site-packages/imblearn/under_sampling/prototype_selection/one_sided_selection.py:197: DeprecationWarning: in the future out of bounds indices will raise an error instead of being ignored by `numpy.delete`.
    idx_maj_extracted = np.delete(idx_maj, idx_maj_sample, axis=0)

-- Docs: http://doc.pytest.org/en/latest/warnings.html
===================== 5 passed, 1 warnings in 7.05 seconds =====================
/nix/store/4id6w8iblacbl9cg6w8fbc3mw22ghzwh-python2.7-imbalanced-learn-0.3.3
/nix/store/ifvjl87nlarvhrmn5s2qdh3jq0s9z7x5-python3.6-imbalanced-learn-0.3.3

GrahamcOfBorg · 2018-04-01T01:08:59Z

Failure on aarch64-linux (full log)

Attempted: python27Packages.imbalanced-learn, python36Packages.imbalanced-learn

Partial log (click to expand)

../../nix/store/ysa7ndiz6mhzh2cpa8dj65myjp7332br-python3.6-pandas-0.22.0/lib/python3.6/site-packages/pandas/tests/io/test_stata.py . [ 65%]
........................................................................ [ 65%]
........................................................................ [ 66%]
........................................................................ [ 66%]
........................................................................ [ 66%]
building of '/nix/store/qaan05bxk57cz3gcqn1ykld9v4884p22-python2.7-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/sfjf2mv5chrnwkq55xlw3znqsggn1zr4-python2.7-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
building of '/nix/store/qs99hvyac7xkv7fzazgqwlhxkvkc0rc1-python3.6-pandas-0.22.0.drv' timed out after 3600 seconds
cannot build derivation '/nix/store/a5f4imgvxh4z7vqklyihqvs4ymix4n34-python3.6-imbalanced-learn-0.3.3.drv': 2 dependencies couldn't be built
�[31;1merror:�[0m build of '/nix/store/a5f4imgvxh4z7vqklyihqvs4ymix4n34-python3.6-imbalanced-learn-0.3.3.drv', '/nix/store/sfjf2mv5chrnwkq55xlw3znqsggn1zr4-python2.7-imbalanced-learn-0.3.3.drv' failed

dotlambda · 2018-04-01T09:15:32Z

Backported in da36dff.

xeji requested a review from FRidh as a code owner March 31, 2018 17:55

GrahamcOfBorg added 6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 labels Mar 31, 2018

dotlambda reviewed Mar 31, 2018

View reviewed changes

pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build

6b2bc4b

minor bump, fix tests, move to development/python-modules

xeji force-pushed the p/imbalanced-learn branch from f789a4d to 6b2bc4b Compare March 31, 2018 23:58

dotlambda merged commit dd7900a into NixOS:master Apr 1, 2018

xeji deleted the p/imbalanced-learn branch April 1, 2018 09:38

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build #38245

pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build #38245

xeji commented Mar 31, 2018

xeji commented Mar 31, 2018

GrahamcOfBorg commented Mar 31, 2018

GrahamcOfBorg commented Mar 31, 2018

dotlambda Mar 31, 2018

xeji Mar 31, 2018

dotlambda Mar 31, 2018

xeji Mar 31, 2018

dotlambda Mar 31, 2018

xeji Mar 31, 2018

xeji commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

dotlambda commented Apr 1, 2018

		{ stdenv, buildPythonPackage, fetchPypi, scikitlearn, pandas, nose, pytest }:

		buildPythonPackage rec {

pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build #38245

pythonPackages.imbalanced-learn: 0.3.2 -> 0.3.3, fix build #38245

Conversation

xeji commented Mar 31, 2018

Motivation for this change

Things done

xeji commented Mar 31, 2018

GrahamcOfBorg commented Mar 31, 2018

GrahamcOfBorg commented Mar 31, 2018

dotlambda Mar 31, 2018

Choose a reason for hiding this comment

xeji Mar 31, 2018

Choose a reason for hiding this comment

dotlambda Mar 31, 2018

Choose a reason for hiding this comment

xeji Mar 31, 2018

Choose a reason for hiding this comment

dotlambda Mar 31, 2018

Choose a reason for hiding this comment

xeji Mar 31, 2018

Choose a reason for hiding this comment

xeji commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

GrahamcOfBorg commented Apr 1, 2018

dotlambda commented Apr 1, 2018