libnvidia-container: fix cross-compilation for aarch64-linux #372148
Merged
+14
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ofborg
bot
added
the
6.topic: cross-compilation
github-actions
bot
added
10.rebuild-darwin: 0
avnik
force-pushed
the
avnik/libnvidia-container-cross
branch
from
cf3ee00 to
8763cdb
Compare
|
Will give this a spin on my x86 box tomorrow! Thanks for the patch. Diff LGTM so far, but I'd still want to test it. |
|
13 tasks
wegank
added
12.approvals: 1
Mic92
reviewed
Jan 10, 2025
Signed-off-by: Alexander V. Nikolaev <[email protected]>
avnik
force-pushed
the
avnik/libnvidia-container-cross
branch
from
8763cdb to
a5fef0d
Compare
|
|
I discovered now that this patch causes some dangling library symlinks in the output. Non-critical, but will fix. It's specifically the below lines causing it: substituteInPlace mk/common.mk \
--replace-fail objcopy '$(OBJCOPY)' \
--replace-fail ldconfig true |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fix cross-compilation issues on aarch64-linux
Note: I didn't test resulting binaries on x86, because haven't nvidia in my x86_64 box
(probably need more testing on aarch64 Tegra as well)
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.