Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

python312Packages.cleanlab: fix build by patching numpy2 incompatibilities #372059

Merged
merged 1 commit into from
Jan 9, 2025

Conversation

GaetanLepage
Copy link
Contributor

@GaetanLepage GaetanLepage commented Jan 8, 2025

Things done

Upstream issue: cleanlab/cleanlab#1151
and PR: cleanlab/cleanlab#1224

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372059


x86_64-linux

✅ 2 packages built:
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist

aarch64-linux

✅ 2 packages built:
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist

@GaetanLepage GaetanLepage requested a review from kirillrdy January 8, 2025 09:18
@fabaff
Copy link
Member

fabaff commented Jan 8, 2025

Hmmm, for me nix-review complains...

[...]
warning: ignoring the client-specified setting 'sandbox', because it is a restricted setting and you are not a trusted user
error: builder for '/nix/store/sgliknp275f2f6fjzhgcilj5w7yn1a9s-numpy2-compatibility.drv' failed with exit code 1;
       last 7 log lines:
       >
       > trying https://github.com/cleanlab/cleanlab/pull/1224/commits/e43e1dafcddf97d19f9f30b4ae1df6fedb89e4d7.patch
       >   % Total    % Received % Xferd  Average Speed   Time    Time     Time  Current
       >                                  Dload  Upload   Total   Spent    Left  Speed
       >   0     0    0     0    0     0      0      0 --:--:-- --:--:-- --:--:--     0
       > curl: (22) The requested URL returned error: 406
       > error: cannot download numpy2-compatibility from any mirror
       For full logs, run 'nix-store -l /nix/store/sgliknp275f2f6fjzhgcilj5w7yn1a9s-numpy2-compatibility.drv'.
error: 1 dependencies of derivation '/nix/store/xbkwb99pfxmgk7igg9yqgjapf8j64n1p-python3.12-cleanlab-2.7.0.drv' failed to build
error: 1 dependencies of derivation '/nix/store/0r95bc3fiqdmjrg8m81vy45yplp7fwg4-review-shell.drv' failed to build

@GaetanLepage
Copy link
Contributor Author

Hmmm, for me nix-review complains...

Yes, I forgot that using PR relative commit URLs was a bad idea.
It should be fine now.

@GaetanLepage
Copy link
Contributor Author

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 372059


x86_64-linux

✅ 2 packages built:
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist

aarch64-linux

✅ 2 packages built:
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist

aarch64-darwin

⏩ 2 packages marked as broken and skipped:
  • python312Packages.cleanlab
  • python312Packages.cleanlab.dist

@GaetanLepage GaetanLepage requested a review from NickCao January 9, 2025 14:21
@happysalada happysalada merged commit 04308e4 into NixOS:master Jan 9, 2025
23 of 27 checks passed
@GaetanLepage GaetanLepage deleted the cleanlab branch January 9, 2025 16:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants