cargo-hakari: 0.9.33 → 0.9.35 #371399
cargo-hakari: 0.9.33 → 0.9.35 #371399
Conversation
cargo-hakari: 0.9.33 → 0.9.35
|
|
|
||
| src = fetchFromGitHub { | ||
| owner = "guppy-rs"; | ||
| repo = "guppy"; | ||
| rev = "cargo-hakari-${version}"; | ||
| sha256 = "sha256-oJZiGXsOl00Bim/olYYSqt/p3j6dTw25IURcwdXYrAo="; | ||
| sha256 = "sha256-xMgNk82U32AtMeZJ8v2M0faHLAPkXrdIJHwOJcqE9m8="; |
There was a problem hiding this comment.
error: hash mismatch in fixed-output derivation '/nix/store/yq4m71a5lmfxjz0qrr9a6ccxcj58292g-source.drv':
specified: sha256-xMgNk82U32AtMeZJ8v2M0faHLAPkXrdIJHwOJcqE9m8=
got: sha256-+IjtK4kSm2vThgIxDsBLpoh0j9cDhhEqI6Hr2BmC7hc=
error: 1 dependencies of derivation '/nix/store/b5hfzv01rhdczwqhxkk5qd63ay87y79m-cargo-hakari-0.9.35-vendor.tar.gz.drv' failed to build
error: 2 dependencies of derivation '/nix/store/vvmw3i2j7pjfk3qyls2qakbbflhrxmbc-cargo-hakari-0.9.35.drv' failed to build
error: 1 dependencies of derivation '/nix/store/09c934x64sh5r66if5gqvsv354qbwsds-review-shell.drv' failed to build
The src hash of guppy-rs may be incorrect.
There was a problem hiding this comment.
See also #331244 which I think updates both
Co-authored-by: Jon Gjengset <[email protected]>
|
@momeemt mind retrying your review? |
|
|
Please, squash your commits and force-push branch |
|
|
||
| src = fetchFromGitHub { | ||
| owner = "guppy-rs"; | ||
| repo = "guppy"; | ||
| rev = "cargo-hakari-${version}"; | ||
| sha256 = "sha256-oJZiGXsOl00Bim/olYYSqt/p3j6dTw25IURcwdXYrAo="; | ||
| sha256 = "sha256-+IjtK4kSm2vThgIxDsBLpoh0j9cDhhEqI6Hr2BmC7hc="; |
There was a problem hiding this comment.
| sha256 = "sha256-+IjtK4kSm2vThgIxDsBLpoh0j9cDhhEqI6Hr2BmC7hc="; | |
| hash = "sha256-+IjtK4kSm2vThgIxDsBLpoh0j9cDhhEqI6Hr2BmC7hc="; |
There was a problem hiding this comment.
We need to use hash, since we have already switched to the SRI hash format.
| @@ -6,16 +6,16 @@ | |||
|
|
|||
| rustPlatform.buildRustPackage rec { | |||
| pname = "cargo-hakari"; | |||
| version = "0.9.33"; | |||
| version = "0.9.35"; | |||
|
|
|||
| src = fetchFromGitHub { | |||
| owner = "guppy-rs"; | |||
| repo = "guppy"; | |||
| rev = "cargo-hakari-${version}"; | |||
There was a problem hiding this comment.
| rev = "cargo-hakari-${version}"; | |
| tag = "cargo-hakari-${version}"; |
|
@Rishik-Y I'd be happy to open a new PR with the updated + squashed changes if you're short on time :) |
As nartsisss-san said, I think these changes commits should be squashed a commit. It will be finished, then I would like to approve this pr 👍 |
|
Updated and squashed in #372314 |
|
All good, thanks for bringing it forward in the first place anyway, and hope you resolved your issue! |
#371364
Maintainer Ping
@figsoda @macalinao @Nartsiss
Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.