-
-
Notifications
You must be signed in to change notification settings - Fork 14.8k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
faust2, faust2jack, magnetophonDSP.VoiceOfFaust: fix strictDeps build, disable PIE hardening #370993
base: master
Are you sure you want to change the base?
Conversation
Thanks a ton for the PR! |
nixpkgs-review won't do much here anyway. These fixes will only matter once the defaults (strictDeps, PIE) are flipped. You could review by adding strictDeps = true / |
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
AFAICT the build failure of magnetophonDSP.VoiceOfFaust is due to mrpeach, fixed in #371495
--------- Report for 'x86_64-linux' ---------
1 package marked as broken and skipped:
magnetophonDSP.ConstantDetuneChorus
2 packages failed to build:
faust2csound magnetophonDSP.VoiceOfFaust
18 packages built:
faust2alqt faust2alsa faust2jack faust2jackrust faust2jaqt faust2ladspa faust2lv2 faustPhysicalModeling magnetophonDSP.CharacterCompressor magnetophonDSP.CompBus magnetophonDSP.LazyLimiter magnetophonDSP.MBdistortion magnetophonDSP.RhythmDelay magnetophonDSP.faustCompressors magnetophonDSP.pluginUtils magnetophonDSP.shelfMultiBand mooSpace tambura
error: build log of '/nix/store/6vallp6ngqcrj8mhb0vxab6lxim7aqaw-faust2csound-2.74.6.drv^' is not available
error: build log of '/nix/store/lwmn1xg2bqd7jy4z34w16iqwzs8xyyd8-faust2csound-2.74.6' is not available
error: build log of '/nix/store/rbq80gsnilnd1vypq902xcmzmzhxm83p-VoiceOfFaust-1.1.5.drv^' is not available
error: build log of '/nix/store/rn8gxicxlb26mdd6f41l4vlcb9y4wkzs-VoiceOfFaust-1.1.5' is not available
nixpkgs-review
result
Generated using nixpkgs-review
.
Command: nixpkgs-review pr 370993
x86_64-linux
⏩ 1 package marked as broken and skipped:
- magnetophonDSP.ConstantDetuneChorus
❌ 2 packages failed to build:
- faust2csound
- magnetophonDSP.VoiceOfFaust
✅ 18 packages built:
- faust2alqt
- faust2alsa
- faust2jack
- faust2jackrust
- faust2jaqt
- faust2ladspa
- faust2lv2
- faustPhysicalModeling
- magnetophonDSP.CharacterCompressor
- magnetophonDSP.CompBus
- magnetophonDSP.LazyLimiter
- magnetophonDSP.MBdistortion
- magnetophonDSP.RhythmDelay
- magnetophonDSP.faustCompressors
- magnetophonDSP.pluginUtils
- magnetophonDSP.shelfMultiBand
- mooSpace
- tambura
Build of |
ref. #178468
ref. #205031
Things done