Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

faust2, faust2jack, magnetophonDSP.VoiceOfFaust: fix strictDeps build, disable PIE hardening #370993

Open
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

FliegendeWurst
Copy link
Member

ref. #178468
ref. #205031

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • Fits CONTRIBUTING.md.

@magnetophon
Copy link
Member

Thanks a ton for the PR!
I'd love to test it, but I'm having issues with nixpkgs-review: Mic92/nixpkgs-review#445

@FliegendeWurst
Copy link
Member Author

FliegendeWurst commented Jan 5, 2025

nixpkgs-review won't do much here anyway. These fixes will only matter once the defaults (strictDeps, PIE) are flipped. You could review by adding strictDeps = true / hardeningEnable= [ "pie" ] to the derivation on master and observing the failure.

@lucasew
Copy link
Contributor

lucasew commented Jan 6, 2025

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370993


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • magnetophonDSP.ConstantDetuneChorus
❌ 2 packages failed to build:
  • faust2csound
  • magnetophonDSP.VoiceOfFaust
✅ 18 packages built:
  • faust2alqt
  • faust2alsa
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faustPhysicalModeling
  • magnetophonDSP.CharacterCompressor
  • magnetophonDSP.CompBus
  • magnetophonDSP.LazyLimiter
  • magnetophonDSP.MBdistortion
  • magnetophonDSP.RhythmDelay
  • magnetophonDSP.faustCompressors
  • magnetophonDSP.pluginUtils
  • magnetophonDSP.shelfMultiBand
  • mooSpace
  • tambura

Copy link
Member

@magnetophon magnetophon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

AFAICT the build failure of magnetophonDSP.VoiceOfFaust is due to mrpeach, fixed in #371495

--------- Report for 'x86_64-linux' ---------
1 package marked as broken and skipped:
magnetophonDSP.ConstantDetuneChorus

2 packages failed to build:
faust2csound magnetophonDSP.VoiceOfFaust

18 packages built:
faust2alqt faust2alsa faust2jack faust2jackrust faust2jaqt faust2ladspa faust2lv2 faustPhysicalModeling magnetophonDSP.CharacterCompressor magnetophonDSP.CompBus magnetophonDSP.LazyLimiter magnetophonDSP.MBdistortion magnetophonDSP.RhythmDelay magnetophonDSP.faustCompressors magnetophonDSP.pluginUtils magnetophonDSP.shelfMultiBand mooSpace tambura

error: build log of '/nix/store/6vallp6ngqcrj8mhb0vxab6lxim7aqaw-faust2csound-2.74.6.drv^' is not available
error: build log of '/nix/store/lwmn1xg2bqd7jy4z34w16iqwzs8xyyd8-faust2csound-2.74.6' is not available
error: build log of '/nix/store/rbq80gsnilnd1vypq902xcmzmzhxm83p-VoiceOfFaust-1.1.5.drv^
' is not available
error: build log of '/nix/store/rn8gxicxlb26mdd6f41l4vlcb9y4wkzs-VoiceOfFaust-1.1.5' is not available

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 370993


x86_64-linux

⏩ 1 package marked as broken and skipped:
  • magnetophonDSP.ConstantDetuneChorus
❌ 2 packages failed to build:
  • faust2csound
  • magnetophonDSP.VoiceOfFaust
✅ 18 packages built:
  • faust2alqt
  • faust2alsa
  • faust2jack
  • faust2jackrust
  • faust2jaqt
  • faust2ladspa
  • faust2lv2
  • faustPhysicalModeling
  • magnetophonDSP.CharacterCompressor
  • magnetophonDSP.CompBus
  • magnetophonDSP.LazyLimiter
  • magnetophonDSP.MBdistortion
  • magnetophonDSP.RhythmDelay
  • magnetophonDSP.faustCompressors
  • magnetophonDSP.pluginUtils
  • magnetophonDSP.shelfMultiBand
  • mooSpace
  • tambura

@FliegendeWurst
Copy link
Member Author

Build of magnetophonDSP.VoiceOfFaust might depend on #370582 or some other PR. It works for me.

@wegank wegank added 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package 12.approvals: 1 This PR was reviewed and approved by one reputable person labels Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 11-100 12.approvals: 1 This PR was reviewed and approved by one reputable person 12.approved-by: package-maintainer This PR was reviewed and approved by a maintainer listed in the package
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants