Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pimsync: init at 0.1.0 #369933

Merged
merged 2 commits into from
Jan 1, 2025
Merged

pimsync: init at 0.1.0 #369933

merged 2 commits into from
Jan 1, 2025

Conversation

qxrein
Copy link
Member

@qxrein qxrein commented Jan 1, 2025

Add pimsync, a successor to vdirsyncer written in Rust. It provides calendar and contact synchronization via CalDAV and CardDAV protocols.

Key features:

  • Calendar and contacts synchronization
  • CalDAV and CardDAV support
  • SQLite-based storage
  • Written in Rust for improved performance and safety
  • Configurable via man pages (pimsync.conf)

The package includes:

  • Main binary
  • Man pages built with scdoc
  • Required runtime dependencies (sqlite)

for #369924

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 1, 2025
@qxrein qxrein changed the title pkgs/applications/misc/pimsync: init at 0.1.0 pkgs/by-name/pi/pimsync: init at 0.1.0 Jan 1, 2025
@qxrein
Copy link
Member Author

qxrein commented Jan 1, 2025

failed due to maintainer name is not added in maintainers list

@github-actions github-actions bot added 8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Jan 1, 2025
@teto
Copy link
Member

teto commented Jan 1, 2025

quite happy to see a vdirsyncer successor, and in rust ! are you using it ? does it perform well, is the syntax compatible with vdirsyncer (to know if I can leverage the home-manager module for it) ?
On next push please clean history (but keep your addition as maintainer in a separate commit)

pkgs/by-name/pi/pimsync/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pimsync/package.nix Show resolved Hide resolved
pkgs/by-name/pi/pimsync/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pimsync/package.nix Outdated Show resolved Hide resolved
pkgs/by-name/pi/pimsync/package.nix Outdated Show resolved Hide resolved
@Sigmanificient
Copy link
Member

Sigmanificient commented Jan 1, 2025

I think you need to rename your pr to: pimsync: init at 0.1.0

Make sure to have the following commits:

maintainers: add qxrein
pimsync: init at 0.1.0

@qxrein qxrein changed the title pkgs/by-name/pi/pimsync: init at 0.1.0 pimsync: init at 0.1.0 Jan 1, 2025
@qxrein qxrein requested a review from Sigmanificient January 1, 2025 15:06
Copy link
Member

@Sigmanificient Sigmanificient left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Almost there! As @teto previously said, you'll need to clean the history such that there are only the 2 afford mentioned commits.

See: https://git-scm.com/book/en/v2/Git-Tools-Rewriting-History#_squashing
(You might find a more beginner-friendly resource online)

@qxrein qxrein force-pushed the patch-5 branch 2 times, most recently from cafc41b to 2d6923f Compare January 1, 2025 15:46
@qxrein qxrein requested a review from Sigmanificient January 1, 2025 15:46
@github-actions github-actions bot added 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin and removed 10.rebuild-darwin: 1-10 labels Jan 1, 2025
@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Jan 1, 2025
@qxrein
Copy link
Member Author

qxrein commented Jan 1, 2025

and now it failed

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 and removed 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin labels Jan 1, 2025
@qxrein
Copy link
Member Author

qxrein commented Jan 1, 2025

less goo

@teto
Copy link
Member

teto commented Jan 1, 2025

thanks for the contribution and following up on comments.

@teto teto merged commit 3da007f into NixOS:master Jan 1, 2025
24 of 25 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
8.has: maintainer-list (update) This PR changes `maintainers/maintainer-list.nix` 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 12.approvals: 1 This PR was reviewed and approved by one reputable person
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants