Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

tfp-hpa: 5.2 -> 5.2-untagged-2024-06-10 #369712

Merged
merged 3 commits into from
Dec 31, 2024
Merged

Conversation

7c6f434c
Copy link
Member

Fixes build

Fixes #369227

@nipsy do you have an easy way to test this?

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@nipsy
Copy link

nipsy commented Dec 31, 2024

I do. I was able to successfully boot a TFTP client on my local LAN from this PR build version of tftp-hpa. Thanks!

@7c6f434c 7c6f434c merged commit f329f66 into NixOS:master Dec 31, 2024
23 of 24 checks passed
@7c6f434c
Copy link
Member Author

Thanks for testing!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Build failure: tftp-hpa
2 participants