pythonPackages.regex: fix darwin build #36742
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GrahamcOfBorg
added
6.topic: darwin
FRidh
reviewed
Mar 10, 2018
| @@ -13,11 +13,16 @@ buildPythonPackage rec { | |||
| sha256 = "2353c0e983c4029caf32016f1dddef623c3117ac282a818468c6d2f5d541698d"; | |||
| }; | |||
|
|
|||
| postCheck = '' | |||
| echo "We now run tests ourselves, since the setuptools installer doesn't." | |||
| python -c 'import test_regex; test_regex.test_main();' | |||
There was a problem hiding this comment.
Just tried to fix this, but it seems the python attribute is not in scope. (undefined variable 'python'). Should python be included in the parameter list?
FRidh
reviewed
Mar 10, 2018
| meta = { | ||
| description = "Alternative regular expression module, to replace re"; | ||
| homepage = https://bitbucket.org/mrabarnett/mrab-regex; | ||
| license = lib.licenses.psfl; | ||
| platforms = lib.platforms.linux; | ||
| platforms = lib.platforms.unix; |
The package works fine on darwin. We run some tests to prove this.
knedlsepp
force-pushed
the
fix-pythonPackages.regex-on-darwin
branch
from
fb73da9 to
d289736
Compare
|
@FRidh Incorporated your suggestions. |
|
@GrahamcOfBorg build pythonPackages.regex |
|
No attempt on x86_64-darwin The following builds were skipped because they don't evaluate on x86_64-darwin: pythonPackages.regex No log is available. |
|
Success on x86_64-linux (full log) Attempted: pythonPackages.regex Partial log (click to expand)
|
|
Success on aarch64-linux (full log) Attempted: pythonPackages.regex Partial log (click to expand)
|
LnL7
approved these changes
Mar 11, 2018
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
18.03 ZHF darwin edition: #36454 (Please backport to 18.03!)
The package works fine on darwin. We run some tests to prove this.
Things done
build-use-sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)