[Backport release-24.11] Correct password option docs and add related tests #367384
+317
−34
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
![nix-backports[bot]](https://avatars.githubusercontent.com/u/487568?s=60&v=4){kind=small}
Testing showed that the existing documentation regarding password override ordering was incorrect. This commit corrects the errors and refactors the way the text is constructed to make updating future ordering changes significantly easier. (cherry picked from commit 52ce5ca)
This commit adds two new tests to show that the ordering of password overrides documentation in nixos/modules/config/user-groups.nix is correct. The override behavior differs depending on whether a system has systemd-sysusers enabled, so there are two tests. (cherry picked from commit b84fb1e)
Otherwise the evaluation warnings have a two or even three lines of whitespace between paragraphs. (cherry picked from commit cb9b3fd)
…fy SetCredential check It was kinda weird to assert that the clear-text password was in the unit when the hashed password was the effective one. This change makes it explicit that both are in there and the latter takes precedence. (cherry picked from commit da2c826)
13 tasks
github-actions
bot
added
6.topic: nixos
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Bot-based backport to
release-24.11, triggered by a label in #310484.