Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sd: use new Darwin SDK pattern #367254

Merged
merged 1 commit into from
Dec 22, 2024
Merged

sd: use new Darwin SDK pattern #367254

merged 1 commit into from
Dec 22, 2024

Conversation

aaronjheng
Copy link
Contributor

@aaronjheng aaronjheng commented Dec 22, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@github-actions github-actions bot added 10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Dec 22, 2024
@lucasewd
Copy link

nixpkgs-reviewd workflow started

  • Extra args: ``
  • Free space: true
  • Who asked: lucasew

TARGETS

  • x86_64-linux: true
  • x86_64-darwin: true
  • aarch64-darwin: true

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12454857182

@lucasewd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367254


x86_64-linux

@lucasewd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367254


x86_64-darwin

✅ 1 package built:
  • sd

@NickCao NickCao merged commit 0a569f3 into NixOS:master Dec 22, 2024
31 of 32 checks passed
@lucasewd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367254


aarch64-darwin

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants