geary: Clean up dependencies #367247
Merged
geary: Clean up dependencies #367247
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Following https://gitlab.gnome.org/GNOME/geary/-/commit/adca034818ba2ed8b31e1bc7ae2fcbae1264724b, we removed the mentioned patching in df76d94 but forgot to drop the comment since it was not attached to the removed block.
As far as I can understand https://gitlab.gnome.org/GNOME/geary/-/issues/439, the dependency is only needed for `share/gettext/its/appdata.{its,loc}` files used when generating the POT file, which should not be needed at build time so https://gitlab.gnome.org/GNOME/geary/-/merge_requests/243 should never have been merged. Additionally, `appstream-glib` is no longer maintained and `${appstream}/share/gettext/its/metainfo.{its,loc}` would be used nowadays. Opened https://gitlab.gnome.org/GNOME/geary/-/merge_requests/856, though it is hard to test because `glib` propagates `gettext`, which also has `metainfo.its`. Also note `appstream-glib` is still an optional build time dependency (`appstream-util validate-relax` can be used to validate the AppStream file). But we do not care about that so it is fine that c5aa34f dropped it from `nativeBuildInputs`.
Without this glib tools complain at build time:
[6/708] Generating ui/org.gnome.Geary_h with a custom command
xml-stripblanks preprocessing requested, but XMLLINT is not set, and xmllint is not in PATH
Partially reverts c5aa34f.
github-actions
bot
added
10.rebuild-darwin: 0
uninsane
approved these changes
Dec 22, 2024
just noticed it, not a new error. sounds like it's only used for optional Unity desktop integration. tried adding not a blocker, just dropping that here in case you recognize some easy fix for it. |
|
That probably means the library needs vala in dependencies, maybe a configure flag as well. But not sure if we want this anyway. |
misuzu
approved these changes
Dec 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Things done
Follow up to #366636
cc @uninsane @misuzu
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.