Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

lib2geom: Move gtest back to check inputs #367171

Merged
merged 4 commits into from
Dec 22, 2024
Merged

Conversation

jtojnar
Copy link
Member

@jtojnar jtojnar commented Dec 21, 2024

Things done

Reverts #366690 (comment) and adds tests.

cc @NickCao @misuzu

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

Avoid `doCheck = true` since `makeDerivation` will force-disable it when cross-compiling
(d834ba6) in a way that is not reflected in `finalAttrs`.
This reverts commit 1973e2a and disables building tests instead.
Inkscape is the primary consumer. Also make sure the cross compilation works.
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367171


x86_64-linux

⏩ 2 packages marked as broken and skipped:
  • spring
  • springLobby
✅ 121 packages built:
  • adapta-gtk-theme
  • arc-theme
  • arx-libertatis
  • asciidoc-full
  • asciidoc-full-with-plugins
  • asciidoc-full-with-plugins.dist
  • asciidoc-full.dist
  • ayu-theme-gtk
  • breeze-hacked-cursor-theme
  • capitaine-cursors
  • catppuccin-cursors
  • catppuccin-cursors.frappeBlue
  • catppuccin-cursors.frappeDark
  • catppuccin-cursors.frappeFlamingo
  • catppuccin-cursors.frappeGreen
  • catppuccin-cursors.frappeLavender
  • catppuccin-cursors.frappeLight
  • catppuccin-cursors.frappeMaroon
  • catppuccin-cursors.frappeMauve
  • catppuccin-cursors.frappePeach
  • catppuccin-cursors.frappePink
  • catppuccin-cursors.frappeRed
  • catppuccin-cursors.frappeRosewater
  • catppuccin-cursors.frappeSapphire
  • catppuccin-cursors.frappeSky
  • catppuccin-cursors.frappeTeal
  • catppuccin-cursors.frappeYellow
  • catppuccin-cursors.latteBlue
  • catppuccin-cursors.latteDark
  • catppuccin-cursors.latteFlamingo
  • catppuccin-cursors.latteGreen
  • catppuccin-cursors.latteLavender
  • catppuccin-cursors.latteLight
  • catppuccin-cursors.latteMaroon
  • catppuccin-cursors.latteMauve
  • catppuccin-cursors.lattePeach
  • catppuccin-cursors.lattePink
  • catppuccin-cursors.latteRed
  • catppuccin-cursors.latteRosewater
  • catppuccin-cursors.latteSapphire
  • catppuccin-cursors.latteSky
  • catppuccin-cursors.latteTeal
  • catppuccin-cursors.latteYellow
  • catppuccin-cursors.macchiatoBlue
  • catppuccin-cursors.macchiatoDark
  • catppuccin-cursors.macchiatoFlamingo
  • catppuccin-cursors.macchiatoGreen
  • catppuccin-cursors.macchiatoLavender
  • catppuccin-cursors.macchiatoLight
  • catppuccin-cursors.macchiatoMaroon
  • catppuccin-cursors.macchiatoMauve
  • catppuccin-cursors.macchiatoPeach
  • catppuccin-cursors.macchiatoPink
  • catppuccin-cursors.macchiatoRed
  • catppuccin-cursors.macchiatoRosewater
  • catppuccin-cursors.macchiatoSapphire
  • catppuccin-cursors.macchiatoSky
  • catppuccin-cursors.macchiatoTeal
  • catppuccin-cursors.macchiatoYellow
  • catppuccin-cursors.mochaBlue
  • catppuccin-cursors.mochaDark
  • catppuccin-cursors.mochaFlamingo
  • catppuccin-cursors.mochaGreen
  • catppuccin-cursors.mochaLavender
  • catppuccin-cursors.mochaLight
  • catppuccin-cursors.mochaMaroon
  • catppuccin-cursors.mochaMauve
  • catppuccin-cursors.mochaPeach
  • catppuccin-cursors.mochaPink
  • catppuccin-cursors.mochaRed
  • catppuccin-cursors.mochaRosewater
  • catppuccin-cursors.mochaSapphire
  • catppuccin-cursors.mochaSky
  • catppuccin-cursors.mochaTeal
  • catppuccin-cursors.mochaYellow
  • cinnamon-screensaver
  • clevis
  • clevis.man
  • coreboot-configurator
  • dblatexFull
  • diagrams-as-code
  • diagrams-as-code.dist
  • disorderfs
  • emojione
  • fim
  • find-billy
  • hackneyed
  • hikounomizu
  • inkscape
  • inkscape-extensions.textext
  • inkscape-extensions.textext.dist
  • inkscape-with-extensions
  • iso-flags
  • iso-flags-png-320x240
  • k40-whisperer
  • kakounePlugins.rep
  • lib2geom
  • lib2geom.dev
  • luksmeta
  • lyra-cursors
  • mate.mate-panel-with-applets
  • mate.mate-utils
  • material-cursors
  • mojave-gtk-theme
  • numix-cursor-theme
  • numix-solarized-gtk-theme
  • plata-theme
  • pop-gtk-theme
  • python311Packages.diagrams
  • python311Packages.diagrams.dist
  • python311Packages.osc-diagram
  • python311Packages.osc-diagram.dist
  • python312Packages.diagrams
  • python312Packages.diagrams.dist
  • python312Packages.osc-diagram
  • python312Packages.osc-diagram.dist
  • tang
  • tang.man
  • vimix-cursors
  • volantes-cursors
  • wpa_supplicant_gui

pkgsCross.aarch64-multiplatform.lib2geom also builds fine

@ofborg ofborg bot added the 11.by: package-maintainer This PR was created by the maintainer of the package it changes label Dec 22, 2024
@misuzu misuzu merged commit a422180 into NixOS:master Dec 22, 2024
41 of 42 checks passed
@jtojnar jtojnar deleted the 2geom-cross-tests branch December 22, 2024 12:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer This PR was created by the maintainer of the package it changes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants