Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

libmypaint: fix cross compilation, set strictDeps #367158

Merged
merged 1 commit into from
Dec 22, 2024

Conversation

NickCao
Copy link
Member

@NickCao NickCao commented Dec 21, 2024

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

Add a 👍 reaction to pull requests you find important.

@ofborg ofborg bot added the 6.topic: cross-compilation Building packages on a different platform than they will be used on label Dec 22, 2024
@ofborg ofborg bot requested a review from jtojnar December 22, 2024 03:33
Copy link
Contributor

@misuzu misuzu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 367158


x86_64-linux

⏩ 3 packages marked as broken and skipped:
  • gimpPlugins.exposureBlend
  • gimpPlugins.resynthesizer
  • opentoonz
❌ 1 package failed to build:
  • mypaint
✅ 18 packages built:
  • gimp (gimpPlugins.gimp)
  • gimp-with-plugins
  • gimp.dev (gimpPlugins.gimp.dev)
  • gimpPlugins.bimp
  • gimpPlugins.farbfeld
  • gimpPlugins.fourier
  • gimpPlugins.gap
  • gimpPlugins.gimplensfun
  • gimpPlugins.gmic
  • gimpPlugins.lightning
  • gimpPlugins.lqrPlugin
  • gimpPlugins.texturize
  • gimpPlugins.waveletSharpen
  • krita
  • krita-plugin-gmic
  • libmypaint
  • libmypaint.dev
  • toppler

mypaint is already broken https://hydra.nixos.org/build/269534324

pkgsCross.aarch64-multiplatform.libmypaint builds now

@jtojnar jtojnar merged commit 57debee into NixOS:master Dec 22, 2024
41 of 42 checks passed
@NickCao NickCao deleted the libmypaint branch December 22, 2024 14:53
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
6.topic: cross-compilation Building packages on a different platform than they will be used on 10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants