fwupd: fix cross compilation #367009
Merged
fwupd: fix cross compilation #367009
+1
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Valgrind is a runtime dependency, so it needs to be in `buildInputs`.
github-actions
bot
added
10.rebuild-darwin: 0
|
@ofborg build fwupd fwupd.tests pkgsCross.aarch64-multiplatform.fwupd |
misuzu
added
the
6.topic: cross-compilation
|
@ofborg build fwupd fwupd.tests |
uninsane
approved these changes
Dec 22, 2024
misuzu
approved these changes
Dec 22, 2024
There was a problem hiding this comment.
nixpkgs-review result
Generated using nixpkgs-review.
Command: nixpkgs-review pr 367009
x86_64-linux
❌ 1 package failed to build:
- libsForQt5.discover (plasma5Packages.discover)
✅ 26 packages built:
- fwupd
- fwupd.debug
- fwupd.dev
- fwupd.devdoc
- fwupd.installedTests
- fwupd.lib
- fwupd.man
- gnome-firmware
- gnome-software
- kdePackages.discover
- kdePackages.discover.debug
- kdePackages.discover.dev
- kdePackages.discover.devtools
- libsForQt5.kinfocenter (plasma5Packages.kinfocenter)
- pantheon.elementary-greeter
- pantheon.elementary-onboarding
- pantheon.elementary-settings-daemon
- pantheon.switchboard-plug-about
- pantheon.switchboard-plug-pantheon-shell
- pantheon.switchboard-plug-power
- pantheon.switchboard-plug-security-privacy
- pantheon.switchboard-with-plugs
- pantheon.wingpanel-applications-menu
- pantheon.wingpanel-indicator-power
- pantheon.wingpanel-quick-settings
- pantheon.wingpanel-with-indicators
libsForQt5.discover is already broken https://hydra.nixos.org/build/281464945
Fixes pkgsCross.aarch64-multiplatform.fwupd
|
It's annoying that the macos build from ofborg fails because of the nixos test, I think we should probably include that test in passthru for linux only. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Valgrind is a runtime dependency, so it needs to be in
buildInputs.Things done
nix.conf? (See Nix manual)sandbox = relaxedsandbox = truenix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see nixpkgs-review usage./result/bin/)Add a 👍 reaction to pull requests you find important.