Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

svelte-language-server: 0.17.7 -> 0.17.8 #366727

Merged
merged 1 commit into from
Dec 22, 2024
Merged

svelte-language-server: 0.17.7 -> 0.17.8 #366727

merged 1 commit into from
Dec 22, 2024
+27 −27

Conversation

SymphonySimper
Copy link
Contributor

@SymphonySimper SymphonySimper commented Dec 20, 2024 •
edited
Loading

Things done

  • Built on platform(s)
    • x86_64-linux
    • aarch64-linux
    • x86_64-darwin
    • aarch64-darwin
  • For non-Linux: Is sandboxing enabled in nix.conf? (See Nix manual)
    • sandbox = relaxed
    • sandbox = true
  • Tested, as applicable:
  • Tested compilation of all packages that depend on this change using nix-shell -p nixpkgs-review --run "nixpkgs-review rev HEAD". Note: all changes have to be committed, also see [nixpkgs-review usage]
    (https://github.com/Mic92/nixpkgs-review#usage)
  • Tested basic functionality of all binary files (usually in ./result/bin/)
  • 25.05 Release Notes (or backporting 24.11 and 25.05 Release notes)
    • (Package updates) Added a release notes entry if the change is major or breaking
    • (Module updates) Added a release notes entry if the change is significant
    • (Module addition) Added a release notes entry if adding a new NixOS module
  • Fits CONTRIBUTING.md.

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review

x86_64-linux

✅ 1 package built:
  • svelte-language-server

Add a 👍 reaction to pull requests you find important.

@NixOSInfra NixOSInfra added the 12. first-time contribution This PR is the author's first one; please be gentle! label Dec 20, 2024
qxrein
qxrein approved these changes Dec 20, 2024
View reviewed changes
Copy link
Contributor

@qxrein qxrein left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good to me

@wegank wegank added the 12.approvals: 1 This PR was reviewed and approved by one reputable person label Dec 20, 2024
@lucasewd
Copy link

nixpkgs-reviewd workflow started

  • Extra args: ``
  • Free space: true
  • Who asked: lucasew

TARGETS

  • x86_64-linux: true
  • x86_64-darwin: true
  • aarch64-darwin: true

Status and logs: https://github.com/nixosbrasil/nixpkgs-reviewd/actions/runs/12450009463

@lucasewd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366727

x86_64-linux

✅ 1 package built:
  • svelte-language-server

@lucasewd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366727

x86_64-darwin

✅ 1 package built:
  • svelte-language-server

@lucasewd
Copy link

nixpkgs-review result

Generated using nixpkgs-review.

Command: nixpkgs-review pr 366727

aarch64-darwin

✅ 1 package built:
  • svelte-language-server

@donovanglover donovanglover merged commit 7ff4b7c into NixOS:master Dec 22, 2024
52 of 53 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qxrein qxrein qxrein approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-darwin: 1 10.rebuild-linux: 1-10 10.rebuild-linux: 1 12.approvals: 1 This PR was reviewed and approved by one reputable person 12. first-time contribution This PR is the author's first one; please be gentle!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@SymphonySimper @lucasewd @qxrein @donovanglover @wegank @NixOSInfra